Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

On 10/13/2015 02:12 AM, Markus Armbruster wrote:

>> Hmm, any test that has an empty .err and non-empty .out, but which does
>> not also have an TODO/FIXME stating that it is a bug, is worth checking.
>>  So first, here's the list of non-empty .out files:
>>

> 
> Actually, the point isn't to move the positive test to
> qapi-schema-test.json, the point is to compile-test its generated code.
> Moving it to qapi-schema-test.json accomplishes that.  However, we may
> not want a single, monolithic positive test.  Should we split up
> qapi-schema-test.json instead?  I don't know.  Anyway, let's flush our
> queue first.

If we do split qapi-schema-test, it won't be until after my patches are
flushed :)

> 
> Third case: the generated code isn't worth compile-testing; comparing
> actual to expected .out suffices.
> 
> Let's sort your untagged tests into buckets:
> 
> Not worth compile-testing:
> * comments.json
> * include-simple.json
> * include-repetition.json
> * include-relpath.json
> * indented-expr.json
> * ident-with-escape.json
> 
> Not (completely) covered in qapi-schema-test.json:
> * enum-empty.json
>   Not covered, but should be.

Covered in v8:
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02869.html

> * flat-union-reverse-define.json
>   UserDefOne covers forward reference to struct base, UserDefFlatUnion
>   covers forward reference to union base, and UserDefFlatUnion2 covers
>   forward reference to member.  We may want to cover forward reference
>   to the tag member's type.

Covered in v8

> 
> Covered:
> * returns-int.json
>   'user_def_cmd3' does the job.

Cleaned up in v8

> * args-member-array.json
>   '__org.qemu_x-command' seems good enough.

Not cleaned up yet, so I'll add it to my next round of subset C.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]