Re: [PATCH] Add error message when trying to use make option T= during build/clean

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Francesco,

On 09/29/2015 06:04 PM, Francesco Montorsi wrote:
> From: Francesco Montorsi <fmontorsi@empirix.com>
> 
> ---
>  mk/rte.sdkbuild.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> index 38ec7bd..013aa89 100644
> --- a/mk/rte.sdkbuild.mk
> +++ b/mk/rte.sdkbuild.mk
> @@ -29,6 +29,12 @@
>  #   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>  #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  
> +ifdef T
> +  ifeq ("$(origin T)", "command line")
> +    $(error "Cannot use T= with a build/clean target")
> +  endif
> +endif
> +
>  # If DESTDIR variable is given, install binary dpdk

I tested this patch but it breaks the "make install" command:

  $ make install T=x86_64-native-linuxapp-gcc
  make[5]: Nothing to be done for 'depdirs'.
  Configuration done
  rte.sdkbuild.mk:34: *** "Cannot use T= with a build/clean target".

As the T= argument is given as a command line variable, it is
propagated to the "$(MAKE) all" in rte.sdkinstall.mk.
So I think it's better to keep the current code as is, except if
you have a better idea.

Regards,
Olivier