Re: [PATCH 19/22] drm/i915: BDW: Pipe level Gamma correction

From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Matheson, Annie J" <annie.j.matheson@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	"Barnes, Jesse" <jesse.barnes@intel.com>,
	Kausal Malladi <kausalmalladi@gmail.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH 19/22] drm/i915: BDW: Pipe level Gamma correction
Date: Tue, 13 Oct 2015 19:16:49 +0530	[thread overview]
Message-ID: <561D0B49.5020604@intel.com> (raw)
In-Reply-To: <CACvgo50774Nc-_LkSEGe=QEWTv0Gw2L4_aVyFaV5-QwC6CduqQ@mail.gmail.com>

Regards
Shashank

On 10/13/2015 6:53 PM, Emil Velikov wrote:
> On 10 October 2015 at 06:21, Sharma, Shashank <shashank.sharma@intel.com> wrote:
>> On 10/10/2015 5:09 AM, Emil Velikov wrote:
>>>
>>> Hi Shashank,
>>>
>>> On 9 October 2015 at 20:29, Shashank Sharma <shashank.sharma@intel.com>
> [snip]
>>>> +       switch (num_samples) {
>>>> +       case GAMMA_DISABLE_VALS:
>>>> +
>>>> +               /* Disable Gamma functionality on Pipe */
>>>
>>> Drop the extra newline between the case and the comment ? Here and below.
>>>
>> I was trying to make it look good :(
> Beauty is in the eye of the beholder. The most important part here is
> consistency.
> Afaict there isn't (m)any i915 code the uses this approach, is there ?
> Some of your other patches use this approach while others don't.
>
I prefer to leave one extra line when I have a comment, so that comment 
is more visible, instead of being sandwiched between lines of C code. 
May be I missed some places, so I can make it consistent.
> Regards,
> Emil
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx