From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 13 Oct 2015 16:41:40 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:1980 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27009454AbbJMOljBWo06 (ORCPT ); Tue, 13 Oct 2015 16:41:39 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id DAA3FAB3AB0E3; Tue, 13 Oct 2015 15:41:30 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 13 Oct 2015 15:41:33 +0100 Received: from [192.168.154.94] (192.168.154.94) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Tue, 13 Oct 2015 15:41:32 +0100 Subject: Re: [RFC v2 PATCH 08/14] irq: implement irq_send_ipi To: Thomas Gleixner References: <1444731382-19313-1-git-send-email-qais.yousef@imgtec.com> <1444731382-19313-9-git-send-email-qais.yousef@imgtec.com> CC: , , , , , From: Qais Yousef Message-ID: <561D181C.8000801@imgtec.com> Date: Tue, 13 Oct 2015 15:41:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.94] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49528 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: qais.yousef@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/13/2015 02:40 PM, Thomas Gleixner wrote: > On Tue, 13 Oct 2015, Qais Yousef wrote: > > Lacks kerneldoc > >> +int __irq_desc_send_ipi(struct irq_desc *desc, const struct ipi_mask *dest) >> +{ >> + struct irq_data *data = irq_desc_get_irq_data(desc); >> + struct irq_chip *chip = irq_data_get_irq_chip(data); >> + >> + if (!chip || !chip->irq_send_ipi) >> + return -EINVAL; >> + >> + /* >> + * Do not validate the mask for IPIs marked global. These are >> + * regular IPIs so we can avoid the operation as their target >> + * mask is the cpu_possible_mask. >> + */ >> + if (!dest->global) { >> + if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask, >> + dest->nbits)) >> + return -EINVAL; >> + } > This looks half thought out. You rely on the caller getting the global > bit right. There should be a sanity check for this versus > data->ipi_mask and also you need to validate nbits. Yes I might have rushed this part as I did it last. I'll improve it. > >> +EXPORT_SYMBOL(irq_send_ipi); > EXPORT_SYMBOL_GPL please > > OK. Thanks, Qais From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:1980 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27009454AbbJMOljBWo06 (ORCPT ); Tue, 13 Oct 2015 16:41:39 +0200 Subject: Re: [RFC v2 PATCH 08/14] irq: implement irq_send_ipi References: <1444731382-19313-1-git-send-email-qais.yousef@imgtec.com> <1444731382-19313-9-git-send-email-qais.yousef@imgtec.com> From: Qais Yousef Message-ID: <561D181C.8000801@imgtec.com> Date: Tue, 13 Oct 2015 15:41:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, jiang.liu@linux.intel.com, ralf@linux-mips.org, linux-mips@linux-mips.org Message-ID: <20151013144132.q8a9f1roAwA-3BF04MCqwkCsrIojN6HZJiLExOpT-sc@z> On 10/13/2015 02:40 PM, Thomas Gleixner wrote: > On Tue, 13 Oct 2015, Qais Yousef wrote: > > Lacks kerneldoc > >> +int __irq_desc_send_ipi(struct irq_desc *desc, const struct ipi_mask *dest) >> +{ >> + struct irq_data *data = irq_desc_get_irq_data(desc); >> + struct irq_chip *chip = irq_data_get_irq_chip(data); >> + >> + if (!chip || !chip->irq_send_ipi) >> + return -EINVAL; >> + >> + /* >> + * Do not validate the mask for IPIs marked global. These are >> + * regular IPIs so we can avoid the operation as their target >> + * mask is the cpu_possible_mask. >> + */ >> + if (!dest->global) { >> + if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask, >> + dest->nbits)) >> + return -EINVAL; >> + } > This looks half thought out. You rely on the caller getting the global > bit right. There should be a sanity check for this versus > data->ipi_mask and also you need to validate nbits. Yes I might have rushed this part as I did it last. I'll improve it. > >> +EXPORT_SYMBOL(irq_send_ipi); > EXPORT_SYMBOL_GPL please > > OK. Thanks, Qais