From mboxrd@z Thu Jan 1 00:00:00 1970 From: sbranden@broadcom.com (Scott Branden) Date: Tue, 13 Oct 2015 09:58:15 -0700 Subject: [PATCH 2/2] dt-bindings: Add new boards to bcm4708 DT bindings In-Reply-To: <561923BC.5040906@hauke-m.de> References: <1443824564-17291-1-git-send-email-jonmason@broadcom.com> <1443824564-17291-2-git-send-email-jonmason@broadcom.com> <561923BC.5040906@hauke-m.de> Message-ID: <561D3827.1000406@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jon, One question below. On 15-10-10 07:42 AM, Hauke Mehrtens wrote: > On 10/03/2015 12:22 AM, Jon Mason wrote: >> Add the 4708, 4709, and 953012k SVKs to the the documentation for the >> Broadcom Northstar device tree bindings. >> >> Signed-off-by: Jon Mason >> --- >> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt >> index 6b0f49f..bdf4c06 100644 >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt > > What should be documented in this file? This is more a question to the > guys more familiar with arm in Linux. Currently the Linux kernel only > supports brcm,bcm4708 and all goes back to that one. > >> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties: >> >> Required root node property: >> >> +bcm94709 >> compatible = "brcm,bcm4708"; >> + >> +bcm94709 >> +compatible = "brcm,bcm4709", "brcm,bcm4708"; >> + >> +bcm953012k >> +compatible = "brcm,bcm5301k", "brcm,bcm4708"; Why are you adding a "k" on the string here? bcm5301k is not an SoC part number? >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Branden Subject: Re: [PATCH 2/2] dt-bindings: Add new boards to bcm4708 DT bindings Date: Tue, 13 Oct 2015 09:58:15 -0700 Message-ID: <561D3827.1000406@broadcom.com> References: <1443824564-17291-1-git-send-email-jonmason@broadcom.com> <1443824564-17291-2-git-send-email-jonmason@broadcom.com> <561923BC.5040906@hauke-m.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <561923BC.5040906-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hauke Mehrtens , Jon Mason , Florian Fainelli , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Jon, One question below. On 15-10-10 07:42 AM, Hauke Mehrtens wrote: > On 10/03/2015 12:22 AM, Jon Mason wrote: >> Add the 4708, 4709, and 953012k SVKs to the the documentation for the >> Broadcom Northstar device tree bindings. >> >> Signed-off-by: Jon Mason >> --- >> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt >> index 6b0f49f..bdf4c06 100644 >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt > > What should be documented in this file? This is more a question to the > guys more familiar with arm in Linux. Currently the Linux kernel only > supports brcm,bcm4708 and all goes back to that one. > >> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties: >> >> Required root node property: >> >> +bcm94709 >> compatible = "brcm,bcm4708"; >> + >> +bcm94709 >> +compatible = "brcm,bcm4709", "brcm,bcm4708"; >> + >> +bcm953012k >> +compatible = "brcm,bcm5301k", "brcm,bcm4708"; Why are you adding a "k" on the string here? bcm5301k is not an SoC part number? >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753164AbbJMQ63 (ORCPT ); Tue, 13 Oct 2015 12:58:29 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:30117 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbbJMQ61 (ORCPT ); Tue, 13 Oct 2015 12:58:27 -0400 X-IronPort-AV: E=Sophos;i="5.17,678,1437462000"; d="scan'208";a="77328423" Subject: Re: [PATCH 2/2] dt-bindings: Add new boards to bcm4708 DT bindings To: Hauke Mehrtens , Jon Mason , Florian Fainelli , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Russell King References: <1443824564-17291-1-git-send-email-jonmason@broadcom.com> <1443824564-17291-2-git-send-email-jonmason@broadcom.com> <561923BC.5040906@hauke-m.de> CC: , , , From: Scott Branden Message-ID: <561D3827.1000406@broadcom.com> Date: Tue, 13 Oct 2015 09:58:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <561923BC.5040906@hauke-m.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jon, One question below. On 15-10-10 07:42 AM, Hauke Mehrtens wrote: > On 10/03/2015 12:22 AM, Jon Mason wrote: >> Add the 4708, 4709, and 953012k SVKs to the the documentation for the >> Broadcom Northstar device tree bindings. >> >> Signed-off-by: Jon Mason >> --- >> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt >> index 6b0f49f..bdf4c06 100644 >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt > > What should be documented in this file? This is more a question to the > guys more familiar with arm in Linux. Currently the Linux kernel only > supports brcm,bcm4708 and all goes back to that one. > >> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties: >> >> Required root node property: >> >> +bcm94709 >> compatible = "brcm,bcm4708"; >> + >> +bcm94709 >> +compatible = "brcm,bcm4709", "brcm,bcm4708"; >> + >> +bcm953012k >> +compatible = "brcm,bcm5301k", "brcm,bcm4708"; Why are you adding a "k" on the string here? bcm5301k is not an SoC part number? >> >