From: "Roger B. Melton" <rmelton@cisco.com>
To: dev@dpdk.org
Subject: Re: [PATCH 2/2] igb: fix VF statistic wraparound handling macro
Date: Tue, 13 Oct 2015 15:44:08 -0400 [thread overview]
Message-ID: <561D5F08.6030708@cisco.com> (raw)
In-Reply-To: <1444668333-20191-3-git-send-email-harry.van.haaren@intel.com>
ack
On 10/12/15 12:45 PM, Harry van Haaren wrote:
> Fix a misinterpreatation of VF statistic macro in e1000/igb.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 848ef6e..e4911fc 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -246,11 +246,10 @@ static void eth_igb_configure_msix_intr(struct rte_eth_dev *dev);
> #define UPDATE_VF_STAT(reg, last, cur) \
> { \
> u32 latest = E1000_READ_REG(hw, reg); \
> - cur += latest - last; \
> + cur += (latest-last) & UINT_MAX; \
> last = latest; \
> }
>
> -
> #define IGB_FC_PAUSE_TIME 0x0680
> #define IGB_LINK_UPDATE_CHECK_TIMEOUT 90 /* 9s */
> #define IGB_LINK_UPDATE_CHECK_INTERVAL 100 /* ms */
--
____________________________________________________________________
|Roger B. Melton | | Cisco Systems |
|CPP Software :|: :|: 7100 Kit Creek Rd |
|+1.919.476.2332 phone :|||: :|||: RTP, NC 27709-4987 |
|+1.919.392.1094 fax .:|||||||:..:|||||||:. rmelton@cisco.com |
| |
| This email may contain confidential and privileged material for the|
| sole use of the intended recipient. Any review, use, distribution |
| or disclosure by others is strictly prohibited. If you are not the |
| intended recipient (or authorized to receive for the recipient), |
| please contact the sender by reply email and delete all copies of |
| this message. |
| |
| For corporate legal information go to: |
| http://www.cisco.com/web/about/doing_business/legal/cri/index.html |
|__________________________ http://www.cisco.com ____________________|
next prev parent reply other threads:[~2015-10-13 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 13:33 [PATCH 0/2] fix vf statistic wraparound handling in macro Harry van Haaren
2015-10-12 13:33 ` [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro Harry van Haaren
2015-10-12 14:45 ` Roger B. Melton
2015-10-12 15:41 ` Alexander Duyck
2015-10-12 16:45 ` [PATCH 0/2] fix vf statistic wraparound handling in macro Harry van Haaren
2015-10-12 16:45 ` [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro Harry van Haaren
2015-10-13 19:43 ` Roger B. Melton
2015-10-14 10:15 ` Roger B. Melton
2015-10-28 13:37 ` Thomas Monjalon
2015-10-12 16:45 ` [PATCH 2/2] igb: " Harry van Haaren
2015-10-13 19:44 ` Roger B. Melton [this message]
2015-10-14 10:16 ` Roger B. Melton
2015-10-28 13:40 ` [PATCH 0/2] fix vf statistic wraparound handling in macro Thomas Monjalon
2015-10-13 19:43 ` [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro Roger B. Melton
2015-10-12 13:33 ` [PATCH 2/2] igb: " Harry van Haaren
2015-10-12 15:02 ` Roger B. Melton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D5F08.6030708@cisco.com \
--to=rmelton@cisco.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.