All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel@zonque.org (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: pxa: raumfeld: make some variables static
Date: Wed, 14 Oct 2015 11:29:07 +0200	[thread overview]
Message-ID: <561E2063.8030905@zonque.org> (raw)
In-Reply-To: <1444814866-4639-1-git-send-email-u.kleine-koenig@pengutronix.de>

On 10/14/2015 11:27 AM, Uwe Kleine-K?nig wrote:
> This fixes the following sparse warnings:
> 
> 	arch/arm/mach-pxa/raumfeld.c:510:24: warning: symbol 'raumfeld_w1_gpio_device' was not declared. Should it be static?
> 	arch/arm/mach-pxa/raumfeld.c:632:31: warning: symbol 'raumfeld_spi_platform_data' was not declared. Should it be static?
> 	arch/arm/mach-pxa/raumfeld.c:851:28: warning: symbol 'audio_va_initdata' was not declared. Should it be static?
> 	arch/arm/mach-pxa/raumfeld.c:883:28: warning: symbol 'audio_dummy_initdata' was not declared. Should it be static?
> 	arch/arm/mach-pxa/raumfeld.c:931:28: warning: symbol 'max8660_v6_subdev_data' was not declared. Should it be static?
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Acked-by: Daniel Mack <daniel@zonque.org>


Thanks!

> ---
>  arch/arm/mach-pxa/raumfeld.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 88f70c37ad0d..32ee6ef5ea4f 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -507,7 +507,7 @@ static struct w1_gpio_platform_data w1_gpio_platform_data = {
>  	.ext_pullup_enable_pin	= -EINVAL,
>  };
>  
> -struct platform_device raumfeld_w1_gpio_device = {
> +static struct platform_device raumfeld_w1_gpio_device = {
>  	.name	= "w1-gpio",
>  	.dev	= {
>  		.platform_data = &w1_gpio_platform_data
> @@ -629,7 +629,7 @@ static void __init raumfeld_lcd_init(void)
>   * SPI devices
>   */
>  
> -struct spi_gpio_platform_data raumfeld_spi_platform_data = {
> +static struct spi_gpio_platform_data raumfeld_spi_platform_data = {
>  	.sck		= GPIO_SPI_CLK,
>  	.mosi		= GPIO_SPI_MOSI,
>  	.miso		= GPIO_SPI_MISO,
> @@ -848,7 +848,7 @@ static void __init raumfeld_power_init(void)
>  static struct regulator_consumer_supply audio_va_consumer_supply =
>  	REGULATOR_SUPPLY("va", "0-0048");
>  
> -struct regulator_init_data audio_va_initdata = {
> +static struct regulator_init_data audio_va_initdata = {
>  	.consumer_supplies = &audio_va_consumer_supply,
>  	.num_consumer_supplies = 1,
>  	.constraints = {
> @@ -880,7 +880,7 @@ static struct regulator_consumer_supply audio_dummy_supplies[] = {
>  	REGULATOR_SUPPLY("vlc", "0-0048"),
>  };
>  
> -struct regulator_init_data audio_dummy_initdata = {
> +static struct regulator_init_data audio_dummy_initdata = {
>  	.consumer_supplies = audio_dummy_supplies,
>  	.num_consumer_supplies = ARRAY_SIZE(audio_dummy_supplies),
>  	.constraints = {
> @@ -928,7 +928,7 @@ static struct regulator_init_data vcc_mmc_init_data = {
>  	.num_consumer_supplies = 1,
>  };
>  
> -struct max8660_subdev_data max8660_v6_subdev_data = {
> +static struct max8660_subdev_data max8660_v6_subdev_data = {
>  	.id		= MAX8660_V6,
>  	.name		= "vmmc",
>  	.platform_data	= &vcc_mmc_init_data,
> 

  reply	other threads:[~2015-10-14  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  9:27 [PATCH] arm: pxa: raumfeld: make some variables static Uwe Kleine-König
2015-10-14  9:29 ` Daniel Mack [this message]
2015-10-14 14:36   ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561E2063.8030905@zonque.org \
    --to=daniel@zonque.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.