Re: [meta-oe][PATCH v2] meta-oe: recipes-graphics: add libvncserver recipe

[Ioan-Adrian Ratiu <adrian.ratiu@ni.com>]

On 13.10.2015 16:08, Martin Jansa wrote:
> On Tue, Oct 13, 2015 at 03:40:20PM +0300, Ioan-Adrian Ratiu wrote:
>> On 13.10.2015 13:53, Martin Jansa wrote:
>>> On Fri, Oct 09, 2015 at 09:58:07AM +0300, Ioan-Adrian Ratiu wrote:
>>>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>>>> ---
>>>>    .../libvncserver/libvncserver_0.9.10.bb               | 19 +++++++++++++++++++
>>>>    1 file changed, 19 insertions(+)
>>>>    create mode 100644 meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
>>>>
>>>> diff --git a/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
>>>> new file mode 100644
>>>> index 0000000..afa303c
>>>> --- /dev/null
>>>> +++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
>>>> @@ -0,0 +1,19 @@
>>>> +DESCRIPTION = "library for easy implementation of a RDP/VNC server"
>
> Use SUMMARY for such short description.
>
>>>> +HOMEPAGE = "https://libvnc.github.io"
>>>> +SECTION = "libs"
>>>> +PRIORITY = "optional"
>
> Drop PRIORITY, we don't use it anywhere.
>
>>>> +LICENSE = "GPLv2"
>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f"
>>>> +
>>>> +DEPENDS += "zlib jpeg libpng gtk+ libgcrypt nettle gnutls gmp"
>>>> +RDEPENDS_${PN} += "libpng gtk+ libgcrypt"
>>>> +
>>>> +RCONFLICTS_${PN} = "x11vnc"
>>>
>>> This isn't enough to resolve conflicts with x11vnc in sysroot, this only
>>> prevent installing both packages in the same image.
>>>
>>>> +
>>>> +inherit autotools pkgconfig
>>>> +
>>>> +SRC_URI  = "git://github.com/LibVNC/libvncserver.git;tag=LibVNCServer-0.9.10"
>>>
>>> Set SRCREV matching with this tag, otherwise bitbake will always use git
>>> ls-remote to convert tag name to git SHA, which won't work for builds
>>> from premirror (possibly without access to network)
>>>
>>
>> This is easy to fix, however the above x11vnc conflict is not and I have
>> to check with upstream developers which might take awhile.
>>
>> Is it ok to blacklist libvncserver in patch v3 in order to not break
>> x11vnc until this is solved?
>
> I don't want to introduce more blacklisted recipes in meta-oe, so this
> won't be merged until it's resolved.
>

This makes sense; it's no rush to get it merged.

Again, thank you for the feedback.

>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +EXTRA_OEMAKE_append=" SUBDIRS='libvncserver' "
>>>> --
>>>> 2.1.4
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>>
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>