From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/Centaur: drop __init annotations
Date: Wed, 14 Oct 2015 14:22:20 +0100
Message-ID: <561E570C.6030009@citrix.com>
References: <561E6F5D02000078000AAE8E@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7227d41b3=Andrew.Cooper3@citrix.com>)
	id 1ZmM0e-00053c-Fj
	for xen-devel@lists.xenproject.org; Wed, 14 Oct 2015 13:22:24 +0000
In-Reply-To: <561E6F5D02000078000AAE8E@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 14/10/15 14:06, Jan Beulich wrote:
> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as
> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing
> the pointers hanging off of it. Even if CPU hotplig support may be
> purely theoretical for Centaur, we should still not leave this as is.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Surely they should be __cpuinit to match __cpuinitdata.

This will have the same effect, as __cpuinit is empty on x86.

~Andrew