From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/Centaur: drop __init annotations Date: Wed, 14 Oct 2015 14:30:21 +0100 Message-ID: <561E58ED.7020803@citrix.com> References: <561E6F5D02000078000AAE8E@prv-mh.provo.novell.com> <561E570C.6030009@citrix.com> <561E744C02000078000AAEDC@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZmM8a-00069d-0O for xen-devel@lists.xenproject.org; Wed, 14 Oct 2015 13:30:36 +0000 In-Reply-To: <561E744C02000078000AAEDC@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 14/10/15 14:27, Jan Beulich wrote: >>>> On 14.10.15 at 15:22, wrote: >> On 14/10/15 14:06, Jan Beulich wrote: >>> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as >>> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing >>> the pointers hanging off of it. Even if CPU hotplig support may be >>> purely theoretical for Centaur, we should still not leave this as is. >>> >>> Signed-off-by: Jan Beulich >> Surely they should be __cpuinit to match __cpuinitdata. >> >> This will have the same effect, as __cpuinit is empty on x86. > Actually all the __{cpu,dev}init{,data} should go away, which is > why I wouldn't want to needlessly add them here. I suppose they should. I will draft a patch. In the mean time, Reviewed-by: Andrew Cooper