From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: kbuild test robot <lkp@intel.com>, <kbuild-all@01.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/11] brcmfmac: expose device memory to devcoredump subsystem
Date: Wed, 14 Oct 2015 15:36:21 +0200 [thread overview]
Message-ID: <561E5A55.5070607@broadcom.com> (raw)
In-Reply-To: <87lhb5n27c.fsf@kamboji.qca.qualcomm.com>
On 10/14/2015 01:01 PM, Kalle Valo wrote:
> Arend van Spriel <arend@broadcom.com> writes:
>
>> On 10/12/2015 10:59 AM, Kalle Valo wrote:
>>> kbuild test robot <lkp@intel.com> writes:
>>>
>>>> Hi Arend,
>>>>
>>>> [auto build test ERROR on next-20151008 -- if it's inappropriate base, please ignore]
>>>>
>>>> config: x86_64-randconfig-x011-201540 (attached as .config)
>>>> reproduce:
>>>> # save the attached .config to linux build tree
>>>> make ARCH=x86_64
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>> drivers/net/wireless/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'
>>>> void brcmf_debugfs_init(void)
>>>> ^
>>>> In file included from drivers/net/wireless/brcm80211/brcmfmac/bus.h:20:0,
>>>> from drivers/net/wireless/brcm80211/brcmfmac/debug.c:24:
>>>> drivers/net/wireless/brcm80211/brcmfmac/debug.h:118:20: note: previous definition of 'brcmf_debugfs_init' was here
>>>> static inline void brcmf_debugfs_init(void)
>>>> ^
>>>
>>> Arend, are the kbuild errors valid? I would guess they are as
>>> wireless-drivers-next should be in linux-next.
>>
>> Actually they are not. I am not sure about the build infrastructure,
>> but the errors above can only occur when CONFIG_BRCMDBG is set, but
>> DEBUG is not. However, that can not happen as we have following line
>> in drivers/net/wireless/brcm80211/Makefile:
>>
>> subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG
>
> I didn't check the details but I'm still not convinced :) In my opinion
> the code should always compile, with and without -DDEBUG. Anyways, I
> pushed this script to the pending branch to get kbuild test this patch
> once again.
Ok, Kalle
Let me try to be a bit more convincing ;-)
I checked out linux-next/master, taken the provided .config and ran:
$ make prepare
$ make M=scripts
$ make M=drivers/net/wireless/brcm80211
WARNING: Symbol version dump ./Module.symvers
is missing; modules will have no dependencies and modversions.
CC drivers/net/wireless/brcm80211/brcmfmac/cfg80211.o
CC drivers/net/wireless/brcm80211/brcmfmac/chip.o
CC drivers/net/wireless/brcm80211/brcmfmac/fwil.o
CC drivers/net/wireless/brcm80211/brcmfmac/fweh.o
CC drivers/net/wireless/brcm80211/brcmfmac/fwsignal.o
CC drivers/net/wireless/brcm80211/brcmfmac/p2p.o
CC drivers/net/wireless/brcm80211/brcmfmac/proto.o
CC drivers/net/wireless/brcm80211/brcmfmac/common.o
CC drivers/net/wireless/brcm80211/brcmfmac/core.o
CC drivers/net/wireless/brcm80211/brcmfmac/firmware.o
CC drivers/net/wireless/brcm80211/brcmfmac/feature.o
CC drivers/net/wireless/brcm80211/brcmfmac/btcoex.o
CC drivers/net/wireless/brcm80211/brcmfmac/vendor.o
CC drivers/net/wireless/brcm80211/brcmfmac/bcdc.o
CC drivers/net/wireless/brcm80211/brcmfmac/sdio.o
CC drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
CC drivers/net/wireless/brcm80211/brcmfmac/debug.o
CC drivers/net/wireless/brcm80211/brcmfmac/tracepoint.o
CC drivers/net/wireless/brcm80211/brcmfmac/of.o
LD drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.o
LD drivers/net/wireless/brcm80211/brcmfmac/built-in.o
CC drivers/net/wireless/brcm80211/brcmutil/utils.o
CC drivers/net/wireless/brcm80211/brcmutil/d11.o
LD drivers/net/wireless/brcm80211/brcmutil/brcmutil.o
LD drivers/net/wireless/brcm80211/brcmutil/built-in.o
LD drivers/net/wireless/brcm80211/built-in.o
Building modules, stage 2.
MODPOST 0 modules
No compile issues.
Regards,
Arend
next prev parent reply other threads:[~2015-10-14 13:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 18:33 [PATCH 00/11] brcmfmac: cfg80211 callbacks and coredump Arend van Spriel
2015-10-08 18:33 ` [PATCH 01/11] brcmfmac: expose device memory to devcoredump subsystem Arend van Spriel
2015-10-08 18:59 ` kbuild test robot
2015-10-12 8:59 ` Kalle Valo
2015-10-12 20:05 ` Arend van Spriel
2015-10-14 11:01 ` Kalle Valo
2015-10-14 13:36 ` Arend van Spriel [this message]
2015-10-15 10:06 ` Kalle Valo
2015-10-21 7:57 ` [01/11] " Kalle Valo
2015-10-08 18:33 ` [PATCH 02/11] brcmfmac: Fix race condition between USB probe/load and disconnect Arend van Spriel
2015-10-08 18:33 ` [PATCH 03/11] brcmfmac: rename firmware_path to alternative_fw_path Arend van Spriel
2015-10-08 18:33 ` [PATCH 04/11] brcmfmac: remove conversational comment Arend van Spriel
2015-10-08 18:33 ` [PATCH 05/11] brcmfmac: Rework p2p attach, use single method for p2p dev creation Arend van Spriel
2015-10-08 18:33 ` [PATCH 06/11] brcmfmac: Fix station info rate information Arend van Spriel
2015-10-08 18:33 ` [PATCH 07/11] brcmfmac: Add RSSI information to get_station Arend van Spriel
2015-10-08 18:33 ` [PATCH 08/11] brcmfmac: Add dump_station support to cfg80221 ops Arend van Spriel
2015-10-08 18:33 ` [PATCH 09/11] brcmfmac: Move brcmf_c_preinit_dcmds prototype to correct file Arend van Spriel
2015-10-08 18:33 ` [PATCH 10/11] brcmfmac: Remove unused state AP creating Arend van Spriel
2015-10-08 18:33 ` [PATCH 11/11] brcmfmac: Properly set carrier state of netdev Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E5A55.5070607@broadcom.com \
--to=arend@broadcom.com \
--cc=kbuild-all@01.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.