From: Daniel Thompson <daniel.thompson@linaro.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [cryptodev:master 62/67] drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared
Date: Wed, 14 Oct 2015 16:15:01 +0100 [thread overview]
Message-ID: <561E7175.7050106@linaro.org> (raw)
In-Reply-To: <201510142211.TZbOa7j7%fengguang.wu@intel.com>
On 14/10/15 15:59, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 62f57d05e287e950c6e1246b1dba08e12985195a
> commit: c6a97c42e399ad0d639f616e58e13f0b4ae87626 [62/67] hwrng: stm32 - add support for STM32 HW RNG
> config: i386-allmodconfig (attached as .config)
> reproduce:
> git checkout c6a97c42e399ad0d639f616e58e13f0b4ae87626
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_suspend':
>>> drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared (first use in this function)
> struct stm32_rng_private *priv = dev_get_drvdata(pdev);
> ^
> drivers/char/hw_random/stm32-rng.c:163:51: note: each undeclared identifier is reported only once for each function it appears in
> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_resume':
> drivers/char/hw_random/stm32-rng.c:172:51: error: 'pdev' undeclared (first use in this function)
> struct stm32_rng_private *priv = dev_get_drvdata(pdev);
> ^
>
> vim +/pdev +163 drivers/char/hw_random/stm32-rng.c
>
> 157 return devm_hwrng_register(dev, &priv->rng);
> 158 }
> 159
> 160 #ifdef CONFIG_PM
> 161 static int stm32_rng_runtime_suspend(struct device *dev)
> 162 {
> > 163 struct stm32_rng_private *priv = dev_get_drvdata(pdev);
> 164
> 165 stm32_rng_cleanup(&priv->rng);
> 166
Oops...
That is a serious oversight on my side. Unlike all my other kernel work
I test the STM32 stuff with a buildroot wrapper. I checked that I had
CONFIG_PM enabled (for good compile coverage) but it looks like I forgot
the "linux-rebuild" when I made final tweaks to the patchset.
I will fix immediately.
Daniel.
prev parent reply other threads:[~2015-10-14 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 14:59 [cryptodev:master 62/67] drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared kbuild test robot
2015-10-14 15:15 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E7175.7050106@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=fengguang.wu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.