Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On 10/14/2015 09:51 AM, Paolo Bonzini wrote:
> 
> 
> On 12/10/2015 17:41, Samuel Thibault wrote:
>> Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a écrit :
>>>  Also, I assume that brlapi_perror() adds additional information to
>>> the error message it prints, such as conversion of a brlapi-specific
>>> error message in the same manner in which perror() converts errno and in
>>> which error_setg_errno() would be used.
>>
>> Yes. Such additional information is really useful to debug brlapi
>> issues.
>>
>>> So I don't know if this
>>> conversion is the best.  But I'm unfamiliar with brlapi_* in general, to
>>> know if there is anything better to use,
>>
>> brlapi_error_t * brlapi_error_location(void);
>> const char * brlapi_strerror(const brlapi_error_t *error);
>>
>> So brlapi_strerror(brlapi_error_location()) will return what you want,
>> i.e. the string that brlapi_error() would have printed.
> 
> Is it okay to squash this?

I'd still like Samuel's confirmation, but from my point of view, that
looks like enough to add:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]