From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 2/5] gpio/xilinx: enable for MIPS Date: Wed, 14 Oct 2015 19:24:47 +0200 Message-ID: <561E8FDF.9070500@metafoo.de> References: <1444827117-10939-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1444827117-10939-3-git-send-email-Zubair.Kakakhel@imgtec.com> <20151014151813.GL15287@xsjsorenbubuntu> <561E7B65.3090704@metafoo.de> <20151014165450.GS15287@xsjsorenbubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151014165450.GS15287@xsjsorenbubuntu> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= Cc: Zubair Lutfullah Kakakhel , ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org On 10/14/2015 06:54 PM, S=C3=B6ren Brinkmann wrote: > On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: >> On 10/14/2015 05:18 PM, S=C3=B6ren Brinkmann wrote: >>> On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrot= e: >>>> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. >>>> >>>> Signed-off-by: Zubair Lutfullah Kakakhel >>>> --- >>>> drivers/gpio/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig >>>> index 8949b3f..58e9afd 100644 >>>> --- a/drivers/gpio/Kconfig >>>> +++ b/drivers/gpio/Kconfig >>>> @@ -508,7 +508,7 @@ config GPIO_XGENE_SB >>>> =20 >>>> config GPIO_XILINX >>>> tristate "Xilinx GPIO support" >>>> - depends on OF_GPIO && (PPC || MICROBLAZE || ARCH_ZYNQ || X86) >>>> + depends on OF_GPIO && (PPC || MICROBLAZE || ARCH_ZYNQ || X86 || = MIPS) >>> >>> Hmm, in general, this driver is hopefully generic enough that it do= esn't >>> have any real architecture dependencies. And I suspect, we want to >>> enable this driver for ARM64 for ZynqMP soon too. Should we probabl= y >>> drop these arch dependencies completely? It seems to become quite a= long list. >> >> I've been thinking about this a while ago. This is certainly not the= only >> driver affected by this problem. But the thing is people always comp= lain if >> new symbols become visable in Kconfig that don't apply to their plat= form. >> >> Maybe we should introduce a HAS_REPROGRAMABLE_LOGIC (or similar) fea= ture >> Kconfig symbol and let platforms which have a FPGA select it and let= drivers >> for FPGA peripherals depend on it. >=20 > Sounds like a good idea to me. But, does that work for all use-cases. > E.g. if you plug some PCIe card with an FPGA into an x86(_64) machine= =2E > That would allow you to use those drivers, but I'm not sure how that > could pull in the new config symbol. Hm, right. We could also make it a user-selectable config symbol. In th= at case you only need to disable one symbol when you don't have FPGA suppo= rt rather than one for each driver. Although I'm not quite sure where to p= ut such a symbol. - Lars -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 14 Oct 2015 19:24:51 +0200 (CEST) Received: from smtp-out-188.synserver.de ([212.40.185.188]:1041 "EHLO smtp-out-188.synserver.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010170AbbJNRYtSj7Lj (ORCPT ); Wed, 14 Oct 2015 19:24:49 +0200 Received: (qmail 28232 invoked by uid 0); 14 Oct 2015 17:24:48 -0000 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 28177 Received: from p4fde7f29.dip0.t-ipconnect.de (HELO ?192.168.2.127?) [79.222.127.41] by 217.119.54.73 with AES128-SHA encrypted SMTP; 14 Oct 2015 17:24:48 -0000 Message-ID: <561E8FDF.9070500@metafoo.de> Date: Wed, 14 Oct 2015 19:24:47 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= CC: Zubair Lutfullah Kakakhel , ralf@linux-mips.org, robh+dt@kernel.org, linus.walleij@linaro.org, linux-mips@linux-mips.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] gpio/xilinx: enable for MIPS References: <1444827117-10939-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1444827117-10939-3-git-send-email-Zubair.Kakakhel@imgtec.com> <20151014151813.GL15287@xsjsorenbubuntu> <561E7B65.3090704@metafoo.de> <20151014165450.GS15287@xsjsorenbubuntu> In-Reply-To: <20151014165450.GS15287@xsjsorenbubuntu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49553 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: lars@metafoo.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/14/2015 06:54 PM, Sören Brinkmann wrote: > On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: >> On 10/14/2015 05:18 PM, Sören Brinkmann wrote: >>> On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: >>>> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. >>>> >>>> Signed-off-by: Zubair Lutfullah Kakakhel >>>> --- >>>> drivers/gpio/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig >>>> index 8949b3f..58e9afd 100644 >>>> --- a/drivers/gpio/Kconfig >>>> +++ b/drivers/gpio/Kconfig >>>> @@ -508,7 +508,7 @@ config GPIO_XGENE_SB >>>> >>>> config GPIO_XILINX >>>> tristate "Xilinx GPIO support" >>>> - depends on OF_GPIO && (PPC || MICROBLAZE || ARCH_ZYNQ || X86) >>>> + depends on OF_GPIO && (PPC || MICROBLAZE || ARCH_ZYNQ || X86 || MIPS) >>> >>> Hmm, in general, this driver is hopefully generic enough that it doesn't >>> have any real architecture dependencies. And I suspect, we want to >>> enable this driver for ARM64 for ZynqMP soon too. Should we probably >>> drop these arch dependencies completely? It seems to become quite a long list. >> >> I've been thinking about this a while ago. This is certainly not the only >> driver affected by this problem. But the thing is people always complain if >> new symbols become visable in Kconfig that don't apply to their platform. >> >> Maybe we should introduce a HAS_REPROGRAMABLE_LOGIC (or similar) feature >> Kconfig symbol and let platforms which have a FPGA select it and let drivers >> for FPGA peripherals depend on it. > > Sounds like a good idea to me. But, does that work for all use-cases. > E.g. if you plug some PCIe card with an FPGA into an x86(_64) machine. > That would allow you to use those drivers, but I'm not sure how that > could pull in the new config symbol. Hm, right. We could also make it a user-selectable config symbol. In that case you only need to disable one symbol when you don't have FPGA support rather than one for each driver. Although I'm not quite sure where to put such a symbol. - Lars