From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Keep the pflip interrupts always enabled v6
Date: Thu, 15 Oct 2015 11:56:21 +0900 [thread overview]
Message-ID: <561F15D5.6010200@daenzer.net> (raw)
In-Reply-To: <1444850797-3429-1-git-send-email-alexander.deucher@amd.com>
On 15.10.2015 04:26, Alex Deucher wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> This fixes flickering issues caused by prematurely firing pflip
> interrupts.
>
> v2 (chk): add commit message, fix DCE V10/V11 and DM as well
> v3: Re-enable pflip interrupt wherever we re-enable a CRTC
> v4: Enable pflip interrupt in DAL as well
> v5: drop DAL changes for upstream
> v6: (agd): only enable interrupts on crtcs that exist
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable ?
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> index fcd2ed5..5727471 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> @@ -233,6 +233,24 @@ static u32 dce_v11_0_vblank_get_counter(struct amdgpu_device *adev, int crtc)
> return RREG32(mmCRTC_STATUS_FRAME_COUNT + crtc_offsets[crtc]);
> }
>
> +static void dce_v11_0_pageflip_interrupt_init(struct amdgpu_device *adev)
> +{
> + unsigned i;
> +
> + /* Enable pflip interrupts */
> + for (i = AMDGPU_PAGEFLIP_IRQ_D1; i < adev->mode_info.num_crtc; i++)
> + amdgpu_irq_get(adev, &adev->pageflip_irq, i);
> +}
> +
> +static void dce_v11_0_pageflip_interrupt_fini(struct amdgpu_device *adev)
> +{
> + unsigned i;
> +
> + /* Disable pflip interrupts */
> + for (i = AMDGPU_PAGEFLIP_IRQ_D1; i < adev->mode_info.num_crtc; i++)
> + amdgpu_irq_put(adev, &adev->pageflip_irq, i);
> +}
It might be less confusing to use 0 instead of AMDGPU_PAGEFLIP_IRQ_D1
now as well, but I'm fine either way.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-10-15 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 19:26 [PATCH] drm/amdgpu: Keep the pflip interrupts always enabled v6 Alex Deucher
2015-10-15 2:56 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561F15D5.6010200@daenzer.net \
--to=michel@daenzer.net \
--cc=alexdeucher@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.