From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v5 5/9] null: export eth_dev_null_create Date: Thu, 15 Oct 2015 17:16:36 +0900 Message-ID: <561F60E4.609@igel.co.jp> References: <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-6-git-send-email-tomaszx.kulasek@intel.com> <561DB149.80604@igel.co.jp> <60ABE07DBB3A454EB7FAD707B4BB1582139C57E4@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Jastrzebski, MichalX K" Return-path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id E8F7B8E90 for ; Thu, 15 Oct 2015 10:16:39 +0200 (CEST) Received: by pabws5 with SMTP id ws5so17003466pab.3 for ; Thu, 15 Oct 2015 01:16:39 -0700 (PDT) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB1582139C57E4@IRSMSX109.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2015/10/14 21:42, Jastrzebski, MichalX K wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Wednesday, October 14, 2015 3:35 AM >> To: Kulasek, TomaszX; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create >> >> On 2015/09/30 23:05, Tomasz Kulasek wrote: >>> Signed-off-by: Tomasz Kulasek >>> --- >>> drivers/net/null/Makefile | 2 +- >>> drivers/net/null/rte_eth_null.c | 2 +- >>> drivers/net/null/rte_eth_null.h | 40 >> +++++++++++++++++++++++++++++ >>> drivers/net/null/rte_pmd_null_version.map | 7 +++++ >>> 4 files changed, 49 insertions(+), 2 deletions(-) >>> create mode 100644 drivers/net/null/rte_eth_null.h >> Acked-by: Tetsuya Mukawa > Hi Tetsuya, > Thank You for a review and acking patches. > There are 5 remaining patches in a patch-set: > > [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration > [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration > [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats > [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos > [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding > > Could You also review them and ack if You agree with that implementation, please? Hi MichalX, I've checked above patches. But I am sorry that I am not a correct person to ack your patches. To review it correctly, at least knowledge about RSS and bonding PMD are needed, but honestly I am not familiar with RSS. Is it possible to find a correct person who can ack it? BTW, I've checked the patch from the following point of view. It may help other reviewers. (I've checked after fixing null PMD issues I've found today, please check an email I've sent to Tomasz) - No fatal errors are reported by checkpatch.pl. - Some style warnings are reported, but I guess we can ignore it. - No compile error with gcc-4.6/4.7/4.8/4.9/5, clang and icc. - No missing symbol. - No compile error for docs. - No compile error for examples. Thanks, Tetsuya