All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Tom Herbert <tom@herbertland.com>,
	davem@davemloft.net, netdev@vger.kernel.org, ast@plumgrid.com
Cc: kernel-team@fb.com
Subject: Re: [PATCH net-next] bpf: Need to call bpf_prog_uncharge_memlock from bpf_prog_put
Date: Thu, 15 Oct 2015 10:42:02 +0200	[thread overview]
Message-ID: <561F66DA.7020804@iogearbox.net> (raw)
In-Reply-To: <1444858844-883196-1-git-send-email-tom@herbertland.com>

On 10/14/2015 11:40 PM, Tom Herbert wrote:
> Currently, is only called from __prog_put_rcu in the bpf_prog_release
> path. Need this to call this from bpf_prog_put also to get correct
> accounting.
>
> Fixes: commit aaac3ba95e4c8b49 ("bpf: charge user for creation of BPF maps and programs")

Btw, "commit" should not be part of the Fixes tag (see SubmittingPatches +187).

> Signed-off-by: Tom Herbert <tom@herbertland.com>

Fix looks good to me, so:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

  parent reply	other threads:[~2015-10-15  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 21:40 [PATCH net-next] bpf: Need to call bpf_prog_uncharge_memlock from bpf_prog_put Tom Herbert
2015-10-14 21:51 ` Alexei Starovoitov
2015-10-15  8:42 ` Daniel Borkmann [this message]
2015-10-16  8:02 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561F66DA.7020804@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.