From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH for-next 2/7] IB: Introduce Work Queue object and its verbs Date: Thu, 15 Oct 2015 11:50:24 +0300 Message-ID: <561F68D0.4050205@dev.mellanox.co.il> References: <1444893410-13242-1-git-send-email-yishaih@mellanox.com> <1444893410-13242-3-git-send-email-yishaih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1444893410-13242-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yishai Hadas , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alexv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org Hi Yishai, > +/** > + * ib_create_wq - Creates a WQ associated with the specified protection > + * domain. > + * @pd: The protection domain associated with the WQ. > + * @wq_init_attr: A list of initial attributes required to create the > + * WQ. If WQ creation succeeds, then the attributes are updated to > + * the actual capabilities of the created WQ. > + * > + * wq_init_attr->max_wr and wq_init_attr->max_sge determine > + * the requested size of the WQ, and set to the actual values allocated > + * on return. > + * If ib_create_wq() succeeds, then max_wr and max_sge will always be > + * at least as large as the requested values. > + * > + * Return Value > + * ib_create_wq() returns a pointer to the created WQ, or NULL if the request > + * fails. > + */ > +struct ib_wq *ib_create_wq(struct ib_pd *pd, > + struct ib_wq_init_attr *init_attr); > + We started shifting function documentations from the header declarations to the *.c implmentations. Would you mind moving it too? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html