From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH] scsi: advansys needs ISA dma api for ISA support Date: Thu, 15 Oct 2015 14:06:15 +0200 Message-ID: <561F96B7.4050300@suse.de> References: <5081546.QjQ32dGX2L@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx2.suse.de ([195.135.220.15]:52121 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbbJOMGR (ORCPT ); Thu, 15 Oct 2015 08:06:17 -0400 In-Reply-To: <5081546.QjQ32dGX2L@wuerfel> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Arnd Bergmann , linux-scsi@vger.kernel.org, JBottomley@odin.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: >=20 > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:11300:10: error: implicit declaration of func= tion 'request_dma' [-Werror=3Dimplicit-function-declaration] >=20 > The problem now showed up in ARM randconfig builds after commit > 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation > warning") made it possible to build on platforms that have neither > VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. >=20 > This adds the missing dependency. >=20 > Signed-off-by: Arnd Bergmann >=20 > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index d2f480b04a52..d4aa6a1a806c 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -499,6 +499,7 @@ config SCSI_ADVANSYS > tristate "AdvanSys SCSI support" > depends on SCSI > depends on ISA || EISA || PCI > + depends on ISA_DMA_API || !ISA > help > This is a driver for all SCSI host adapters manufactured by > AdvanSys. It is documented in the kernel source in >=20 Sorry to chime in again, but wouldn't this allow to build on platforms which have neither ISA_DMA_API nor ISA, like oldish sparc systems with proprietary S-BUS? Why not ISA_DMA_API || EISA || PCI ? Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Thu, 15 Oct 2015 14:06:15 +0200 Subject: [PATCH] scsi: advansys needs ISA dma api for ISA support In-Reply-To: <5081546.QjQ32dGX2L@wuerfel> References: <5081546.QjQ32dGX2L@wuerfel> Message-ID: <561F96B7.4050300@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] > > The problem now showed up in ARM randconfig builds after commit > 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation > warning") made it possible to build on platforms that have neither > VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. > > This adds the missing dependency. > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index d2f480b04a52..d4aa6a1a806c 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -499,6 +499,7 @@ config SCSI_ADVANSYS > tristate "AdvanSys SCSI support" > depends on SCSI > depends on ISA || EISA || PCI > + depends on ISA_DMA_API || !ISA > help > This is a driver for all SCSI host adapters manufactured by > AdvanSys. It is documented in the kernel source in > Sorry to chime in again, but wouldn't this allow to build on platforms which have neither ISA_DMA_API nor ISA, like oldish sparc systems with proprietary S-BUS? Why not ISA_DMA_API || EISA || PCI ? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare at suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbbJOMGT (ORCPT ); Thu, 15 Oct 2015 08:06:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:52121 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbbJOMGR (ORCPT ); Thu, 15 Oct 2015 08:06:17 -0400 Subject: Re: [PATCH] scsi: advansys needs ISA dma api for ISA support To: Arnd Bergmann , linux-scsi@vger.kernel.org, JBottomley@odin.com References: <5081546.QjQ32dGX2L@wuerfel> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <561F96B7.4050300@suse.de> Date: Thu, 15 Oct 2015 14:06:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5081546.QjQ32dGX2L@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] > > The problem now showed up in ARM randconfig builds after commit > 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation > warning") made it possible to build on platforms that have neither > VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. > > This adds the missing dependency. > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index d2f480b04a52..d4aa6a1a806c 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -499,6 +499,7 @@ config SCSI_ADVANSYS > tristate "AdvanSys SCSI support" > depends on SCSI > depends on ISA || EISA || PCI > + depends on ISA_DMA_API || !ISA > help > This is a driver for all SCSI host adapters manufactured by > AdvanSys. It is documented in the kernel source in > Sorry to chime in again, but wouldn't this allow to build on platforms which have neither ISA_DMA_API nor ISA, like oldish sparc systems with proprietary S-BUS? Why not ISA_DMA_API || EISA || PCI ? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)