Re: [PATCH v4 0/7] Add instalation rules for dpdk files.

[Panu Matilainen <pmatilai@redhat.com>]

On 10/10/2015 08:45 PM, Arevalo, Mario Alfredo C wrote:
> Hi,
>
> Good day, I was wondering if someone has any comment about it :)

Hi, sorry been busy with some other agendas :)

See below...

>
> v4:
>
> Modify the makefile target to specify the files
> that will be installed using a rule:
>
> * make install-bin (install app files)(dafault path BIN_DIR=/usr/bin).
>
> * make install-headers (install headers)(dafault path INCLUDE_DIR=/usr/include/dpdk).
>
> * make install-lib (install libraries)(dafault path if the architecture is 64 bits
>                  is LIB_DIR=/usr/lib64 else LIB_DIR=/usr/lib).

I still maintain the LIB_DIR heuristic around x86_64 arch is broken and 
that we'll be better off without it. Even auto*tools and cmake dont try 
to guess this. If you insist on heuristics, you'll need help from other 
tools, eg on systems where systemd-path is available, you can get a 
reasonable well-educated guess from it with "systemd-path 
system-library-arch".

>
> * make install-doc (install documentation)(dafault path DOC_DIR=/usr/share/doc/dpdk).
>
> * make install-mod (install modules)(dafault path if RTE_EXEC_ENV=linuxapp then
>                  KERNEL_DIR=/lib/modules/$(uname -r)/extra/drivers/dpdk else KERNEL_DIR=/boot/modules).

Just noticed, this creates the /lib/modules structure even if there are 
no kernel modules to install. Not the end of the world of course.

> * make install-sdk (install headers, makefiles, scripts,examples, tools and
>                  config files) (default path DATA_DIR=/usr/share/dpdk).
>
> * make install-fhs (install  libraries, modules, app files,
>                  nic bind files and documentation).

I still think that install-fhs should include headers as well, that is 
what all normal OSS software does on "make install" anyway. Or just 
install it all (ie whole -sdk). The documentation installed with 
install-fhs includes things like the programmers guide, which is of 
little use without the sdk bits.

	- Pan u-