All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>,
	Jens Axboe <axboe@kernel.dk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH] blk-mq: fix use-after-free in blk_mq_free_tag_set()
Date: Thu, 15 Oct 2015 08:47:06 -0600	[thread overview]
Message-ID: <561FBC6A.4040909@fb.com> (raw)
In-Reply-To: <20151014050213.GA10302@xzibit.linux.bs1.fc.nec.co.jp>

On 10/13/2015 11:02 PM, Junichi Nomura wrote:
> tags is freed in blk_mq_free_rq_map() and should not be used after that.
> The problem doesn't manifest if CONFIG_CPUMASK_OFFSTACK is false because
> free_cpumask_var() is nop.
> 
> tags->cpumask is allocated in blk_mq_init_tags() so it's natural to
> free cpumask in its counter part, blk_mq_free_tags().

Thanks, applied. tags->cpumask should some day die a horrible death.

-- 
Jens Axboe


      parent reply	other threads:[~2015-10-15 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  5:02 [PATCH] blk-mq: fix use-after-free in blk_mq_free_tag_set() Junichi Nomura
2015-10-15 14:43 ` Jeff Moyer
2015-10-15 14:47 ` Keith Busch
2015-10-15 14:47 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561FBC6A.4040909@fb.com \
    --to=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.