From: Murali Karicheri <m-karicheri2@ti.com>
To: Fabio Estevam <festevam@gmail.com>, <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK
Date: Thu, 15 Oct 2015 12:23:42 -0400 [thread overview]
Message-ID: <561FD30E.20203@ti.com> (raw)
In-Reply-To: <1444042389-8036-1-git-send-email-festevam@gmail.com>
On 10/05/2015 06:53 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Fix Subject
>
> Murali,
>
> I am doing some consolidation on the PCI DW drivers and I noticed that
> keystone uses a different LTSSM_STATE_MASK definition.
>
> Could you please double check it?
>
> drivers/pci/host/pci-keystone-dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
> index 3cf55cd..78320e4 100644
> --- a/drivers/pci/host/pci-keystone-dw.c
> +++ b/drivers/pci/host/pci-keystone-dw.c
> @@ -25,7 +25,7 @@
>
> /* Application register defines */
> #define LTSSM_EN_VAL 1
> -#define LTSSM_STATE_MASK 0x1f
> +#define LTSSM_STATE_MASK 0x3f
NACK
The mask should be 0x1f as was originally as per document
4-0 LTSSM_STATE
LTSSM current state. Please see Appendix
A.1 for the names of the LTSSM states corresponding to
the encoded values.
refer the document at http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf
Murali
> #define LTSSM_STATE_L0 0x11
> #define DBI_CS2_EN_VAL 0x20
> #define OB_XLAT_EN_VAL 2
>
--
Murali Karicheri
Linux Kernel, Keystone
next prev parent reply other threads:[~2015-10-15 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 10:53 [RFC v2] PCI: keystone: Fix definition of LTSSM_STATE_MASK Fabio Estevam
2015-10-15 16:23 ` Murali Karicheri [this message]
2015-10-15 17:16 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561FD30E.20203@ti.com \
--to=m-karicheri2@ti.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.