All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] soc: rockchip: power-domain: don't try to print the clock name in error case
Date: Fri, 16 Oct 2015 09:19:34 +0800	[thread overview]
Message-ID: <562050A6.7080002@gmail.com> (raw)
In-Reply-To: <1764593.eLkUiZigaK@diego>

Heiko,

Thanks to fix it.

在 2015年10月15日 21:22, Heiko Stübner 写道:
> When we never got the the clock-reference, i.e. when IS_ERR(clk) is true,
> don't try to print the clock name via %pC as this of course produces a
> null-pointer-dereference in __clk_get_name().
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Look good to me, you can free add that.

Reviewed-by: Caesar Wang <wxt@rock-chips.com>

> ---
>   drivers/soc/rockchip/pm_domains.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c
> index 8268d5d..534c589 100644
> --- a/drivers/soc/rockchip/pm_domains.c
> +++ b/drivers/soc/rockchip/pm_domains.c
> @@ -265,8 +265,8 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu,
>   		if (IS_ERR(clk)) {
>   			error = PTR_ERR(clk);
>   			dev_err(pmu->dev,
> -				"%s: failed to get clk %pC (index %d): %d\n",
> -				node->name, clk, i, error);
> +				"%s: failed to get clk at index %d: %d\n",
> +				node->name, i, error);
>   			goto err_out;
>   		}
>   
>
> -- 
> Thanks,
> Caesar

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: caesar.upstream@gmail.com (Caesar Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: rockchip: power-domain: don't try to print the clock name in error case
Date: Fri, 16 Oct 2015 09:19:34 +0800	[thread overview]
Message-ID: <562050A6.7080002@gmail.com> (raw)
In-Reply-To: <1764593.eLkUiZigaK@diego>

Heiko,

Thanks to fix it.

? 2015?10?15? 21:22, Heiko St?bner ??:
> When we never got the the clock-reference, i.e. when IS_ERR(clk) is true,
> don't try to print the clock name via %pC as this of course produces a
> null-pointer-dereference in __clk_get_name().
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Look good to me, you can free add that.

Reviewed-by: Caesar Wang <wxt@rock-chips.com>

> ---
>   drivers/soc/rockchip/pm_domains.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c
> index 8268d5d..534c589 100644
> --- a/drivers/soc/rockchip/pm_domains.c
> +++ b/drivers/soc/rockchip/pm_domains.c
> @@ -265,8 +265,8 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu,
>   		if (IS_ERR(clk)) {
>   			error = PTR_ERR(clk);
>   			dev_err(pmu->dev,
> -				"%s: failed to get clk %pC (index %d): %d\n",
> -				node->name, clk, i, error);
> +				"%s: failed to get clk at index %d: %d\n",
> +				node->name, i, error);
>   			goto err_out;
>   		}
>   
>
> -- 
> Thanks,
> Caesar

  reply	other threads:[~2015-10-16  1:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 13:22 [PATCH] soc: rockchip: power-domain: don't try to print the clock name in error case Heiko Stübner
2015-10-15 13:22 ` Heiko Stübner
2015-10-16  1:19 ` Caesar Wang [this message]
2015-10-16  1:19   ` Caesar Wang
2015-10-16  8:17 ` Heiko Stübner
2015-10-16  8:17   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562050A6.7080002@gmail.com \
    --to=caesar.upstream-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.