From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
qemu-block@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: switch off scsi-passthrough by default
Date: Fri, 16 Oct 2015 10:41:45 +0200 [thread overview]
Message-ID: <5620B849.80202@redhat.com> (raw)
In-Reply-To: <1444984830-39886-1-git-send-email-cornelia.huck@de.ibm.com>
On 16/10/2015 10:40, Cornelia Huck wrote:
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -272,6 +272,10 @@ static const TypeInfo ccw_machine_info = {
> .driver = "vhost-scsi-ccw",\
> .property = "max_revision",\
> .value = "0",\
> + },{\
> + .driver = "virtio-blk-ccw",\
> + .property = "scsi",\
> + .value = "true",\
> },
>
> static void ccw_machine_2_4_class_init(ObjectClass *oc, void *data)
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index 095de5d..bbf1ab2 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -2,7 +2,11 @@
> #define HW_COMPAT_H
>
> #define HW_COMPAT_2_4 \
> - /* empty */
> + {\
> + .driver = "virtio-blk-pci",\
> + .property = "scsi",\
> + .value = "true",\
> + },
>
> #define HW_COMPAT_2_3 \
> {\
>
s390 should use HW_COMPAT_2_4 as well. Otherwise looks good.
Paolo
next prev parent reply other threads:[~2015-10-16 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 8:40 [Qemu-devel] [PATCH] virtio-blk: switch off scsi-passthrough by default Cornelia Huck
2015-10-16 8:41 ` Paolo Bonzini [this message]
2015-10-16 8:46 ` Paolo Bonzini
2015-10-16 8:54 ` Cornelia Huck
2015-10-16 9:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620B849.80202@redhat.com \
--to=pbonzini@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.