From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2] libxc: fix the types used in
 xc_dom_image to build HVM guests
Date: Fri, 16 Oct 2015 11:03:54 +0200
Message-ID: <5620BD7A.3010701@citrix.com>
References: <1444929837-17186-1-git-send-email-roger.pau@citrix.com>
	<1444985822.12442.2.camel@citrix.com>
	<20151016090020.GI32638@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=72415c8cf=roger.pau@citrix.com>)
	id 1Zn0vg-0001eM-AV
	for xen-devel@lists.xenproject.org; Fri, 16 Oct 2015 09:04:00 +0000
In-Reply-To: <20151016090020.GI32638@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 16/10/15 a les 11.00, Wei Liu ha escrit:
> On Fri, Oct 16, 2015 at 09:57:02AM +0100, Ian Campbell wrote:
>> On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote:
>>> Fix the types used to store the memory parameters of an HVM guest,
>>> previously they defaulted to unsigned long on 32bit toolstack builds, which
>>> is wrong because a 32bit value cannot hold a 64bit memory address that
>>> crosses the 4GB boundary.
>>
>> Just for my own interest, I suppose this was a latent issue even before the
>> dom builder rework, but what was the change which exposed it now?
>>
> 
> I don't think this is a latent issue.
> 
> During the refactoring a bunch of types were changed to unsigned long.
> The original types used were uint64_t, which is of the same width on 32
> bit and 64 bit.

Yes, those fields were in xc_hvm_build_args as uint64_t, and during the
rework of the HVM builder I had changed them to xen_pfn_t, so it's
completely my fault, previous code should be fine.

I will keep an eye on the smoke OSSTest tests.

Roger.