From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn2rL-0008Fi-CO for qemu-devel@nongnu.org; Fri, 16 Oct 2015 07:07:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn2rH-0000GN-8J for qemu-devel@nongnu.org; Fri, 16 Oct 2015 07:07:39 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:46614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn2rG-0000Fv-VQ for qemu-devel@nongnu.org; Fri, 16 Oct 2015 07:07:35 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Oct 2015 12:07:33 +0100 References: <1444991154-79217-1-git-send-email-cornelia.huck@de.ibm.com> <1444991154-79217-4-git-send-email-cornelia.huck@de.ibm.com> <5620D254.60502@de.ibm.com> <20151016124403.2fa55ceb.cornelia.huck@de.ibm.com> From: Christian Borntraeger Message-ID: <5620DA70.1050702@de.ibm.com> Date: Fri, 16 Oct 2015 13:07:28 +0200 MIME-Version: 1.0 In-Reply-To: <20151016124403.2fa55ceb.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: kwolf@redhat.com, qemu-block@nongnu.org, mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, stefanha@redhat.com, pbonzini@redhat.com Am 16.10.2015 um 12:44 schrieb Cornelia Huck: > On Fri, 16 Oct 2015 12:32:52 +0200 > Christian Borntraeger wrote: > >> Am 16.10.2015 um 12:25 schrieb Cornelia Huck: >>> Devices that are compliant with virtio-1 do not support scsi >>> passthrough any more (and it has not been a recommended setup >>> anyway for quite some time). To avoid having to switch it off >>> explicitly in newer qemus that turn on virtio-1 by default, let's >>> switch the default to scsi=false for 2.5. >>> >>> Signed-off-by: Cornelia Huck >>> --- >>> hw/block/virtio-blk.c | 2 +- >>> include/hw/compat.h | 6 +++++- >>> 2 files changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c >>> index 8beb26b..999dbd7 100644 >>> --- a/hw/block/virtio-blk.c >>> +++ b/hw/block/virtio-blk.c >>> @@ -975,7 +975,7 @@ static Property virtio_blk_properties[] = { >>> DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial), >>> DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true), >>> #ifdef __linux__ >>> - DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true), >>> + DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false), >>> #endif >>> DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0, >>> true), >>> diff --git a/include/hw/compat.h b/include/hw/compat.h >>> index 095de5d..93e71af 100644 >>> --- a/include/hw/compat.h >>> +++ b/include/hw/compat.h >>> @@ -2,7 +2,11 @@ >>> #define HW_COMPAT_H >>> >>> #define HW_COMPAT_2_4 \ >>> - /* empty */ >>> + {\ >>> + .driver = "virtio-blk-device",\ >>> + .property = "scsi",\ >>> + .value = "true",\ >> >> does that work? > > It did for me :) > >> >> If yes, would it make sense to convert the things in HW_COMPAT_2_3 from >> pci to device, e.g. >> >> >> {\ >> - .driver = "virtio-blk-pci",\ >> + .driver = "virtio-blk-device",\ >> .property = "any_layout",\ >> .value = "off",\ >> ... > > Not sure: We don't have 2.3 compat for ccw... but would give a better > template for later changes. Yes. But this can be an addon patch. Lets keep this patch as is to have scsi=off as default for virtio 1.0 (some iotests do fail because of this) Christian