From: Marcel Apfelbaum <marcel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Knut Omang <knut.omang@oracle.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.a@redhat.com>,
qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
Jan Kiszka <jan.kiszka@web.de>,
Paolo Bonzini <pbonzini@redhat.com>,
Dotan Barak <dotanba@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v5 3/4] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt
Date: Fri, 16 Oct 2015 14:27:03 +0300 [thread overview]
Message-ID: <5620DF07.20809@redhat.com> (raw)
In-Reply-To: <20151016135118-mutt-send-email-mst@redhat.com>
On 10/16/2015 01:54 PM, Michael S. Tsirkin wrote:
> On Fri, Oct 16, 2015 at 11:56:39AM +0200, Knut Omang wrote:
>> But feel free to just skip this patch, the most important is to get the
>> generic SR/IOV code in there for others to use.
>
> That's my question. Is it for others to use or are you going to use it
> youself?
>
> If you plan to e.g. complete igb to the point where Linux can use it,
> then I'll merge this.
> BTW for igb it might be easier to copy out e1000 code, at least that's what
> linux guest drivers did.
>
> Alternatively, if someone on list is interested in using this,
> please review and ack.
>
Hi,
Even if nobody is actually going to implement an SR-IOV enabled device
on top of this really soon, having it in QEMU should be handy.
I know at least a hardware vendor that used those bits to emulate their SR-IOV device.
Sadly their code will not come to QEMU, at least not so soon. (I'll ask at least for a "tested-by" tag)
Maybe somebody will want to enable SR-IOV for virtio :)
This is why I proposed to have a "how-to" doc for the first implementation.
The implementer will choose then how to deal with this doc.
I'll go over the code again and add my "Reviewed-by".
Thanks!
Marcel
next prev parent reply other threads:[~2015-10-16 11:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 15:51 [Qemu-devel] [PATCH v5 0/4] pcie: Add support for Single Root I/O Virtualization Knut Omang
2015-10-14 15:51 ` [Qemu-devel] [PATCH v5 1/4] pci: Make use of the devfn property when registering new devices Knut Omang
2015-10-14 15:51 ` [Qemu-devel] [PATCH v5 2/4] pcie: Add support for Single Root I/O Virtualization (SR/IOV) Knut Omang
2015-10-18 11:02 ` Marcel Apfelbaum
2015-10-18 12:26 ` Michael S. Tsirkin
2015-10-18 15:00 ` Knut Omang
2015-10-18 15:57 ` Knut Omang
2015-10-19 9:00 ` Paolo Bonzini
2015-10-14 15:51 ` [Qemu-devel] [PATCH v5 3/4] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt Knut Omang
2015-10-16 8:36 ` Michael S. Tsirkin
2015-10-16 9:56 ` Knut Omang
2015-10-16 10:54 ` Michael S. Tsirkin
2015-10-16 11:25 ` Knut Omang
2015-10-16 11:34 ` Michael S. Tsirkin
2015-10-16 11:39 ` Paolo Bonzini
2015-10-16 11:27 ` Marcel Apfelbaum [this message]
2015-10-16 11:32 ` Richard W.M. Jones
2015-10-16 11:39 ` Michael S. Tsirkin
2015-10-18 11:03 ` Marcel Apfelbaum
2015-10-14 15:51 ` [Qemu-devel] [PATCH v5 4/4] pcie: A few minor fixes (type+code simplify) Knut Omang
2015-10-18 11:03 ` Marcel Apfelbaum
2015-10-18 11:02 ` [Qemu-devel] [PATCH v5 0/4] pcie: Add support for Single Root I/O Virtualization Marcel Apfelbaum
2015-10-18 14:39 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620DF07.20809@redhat.com \
--to=marcel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dotanba@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@web.de \
--cc=knut.omang@oracle.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.