Re: [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On 10/16/2015 04:46 AM, Fam Zheng wrote:
> The word "backing file" nowadays refers to the backing_hd in the
> external snapshot sense (i.e. bs->backing_hd), instead of the file sense
> (bs->file). Correct the comment to use the right term.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/blkdebug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index bc247f4..54650a7 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -426,7 +426,7 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,
>      /* Set initial state */
>      s->state = 1;
>  
> -    /* Open the backing file */
> +    /* Open the image file */
>      assert(bs->file == NULL);
>      ret = bdrv_open_image(&bs->file, qemu_opt_get(opts, "x-image"), options, "image",
>                            bs, &child_file, false, &local_err);
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]