From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org,
Vivek Kasireddy <vivek.kasireddy@intel.com>
Subject: Re: [PATCH i-g-t 1/3] lib/igt_fb: Allow specifiying object tiling when creating frame buffers
Date: Fri, 16 Oct 2015 14:06:00 +0100 [thread overview]
Message-ID: <5620F638.9020509@linux.intel.com> (raw)
In-Reply-To: <20151016130155.GQ26517@intel.com>
On 16/10/15 14:01, Ville Syrjälä wrote:
> On Fri, Oct 16, 2015 at 01:54:51PM +0100, Tvrtko Ursulin wrote:
>>
>> On 16/10/15 13:29, Ville Syrjälä wrote:
>>> On Fri, Oct 16, 2015 at 01:19:35PM +0100, Tvrtko Ursulin wrote:
>>>>
>>>> Hi,
>>>>
>>>> On 16/10/15 13:03, Ville Syrjälä wrote:
>>>>> On Fri, Oct 16, 2015 at 11:59:47AM +0100, Tvrtko Ursulin wrote:
>>>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>>>
>>>>>> Currently object tiling is inferred from the frame buffer modifier
>>>>>> and only for legacy X scanout.
>>>>>>
>>>>>> It is useful to support overriding this selection for certain tests
>>>>>> so add the capability.
>>>>>
>>>>> So you want to set up the object tiling differently from the fb
>>>>> tiling? Why is that? And don't we reject it in the kernel? If we don't
>>>>> need a fence for scanout (ie. FBC or gen2/3) we could allow it I
>>>>> suppose, but not sure it it really helps with anything.
>>>>
>>>> Hm, yes and no. Only different in a sense that currently igt_fb leaves
>>>> object tiling at linear regardless of the fb modifier tiling. (Apart for
>>>> the legacy X where it requires that they match.)
>>>>
>>>> I needed a way of having Y tiled fb modifier and Y tiled object to hit a
>>>> warning in i915_gem_object_get_fence when only the rotated view exists.
>>>
>>> Is there a problem of just doing what X tiled did also for Y tiled?
>>
>> What do you mean? In the kernel or igt_fb? If latter then it needs to be
>> able to have object tiling as linear by default since that is how fb
>> modifiers were intended to be used - decoupled from obj tiling. Is that
>> what you meant?
>
> Just setting obj to Y tiled when fb is Y tiled from igt_fb.
Right, so I explained that - we want to have Y tiled fb modifier +
linear object in the majority of cases, _apart_ from this special test
case which tries to hit a WARN_ON on !obj->map_and_fenceable. Which
happens when obj tiling is Y, and fb tiling is Y, _and_ no normal VMA
exists, just the rotate one.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-16 13:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 10:59 [PATCH i-g-t 1/3] lib/igt_fb: Allow specifiying object tiling when creating frame buffers Tvrtko Ursulin
2015-10-16 10:59 ` [PATCH i-g-t 2/3] lib/igt_kms: Set new rotation property before displaying Tvrtko Ursulin
2015-10-16 10:59 ` [PATCH i-g-t 3/3] kms_rotation_crc: Test case for rotated VMA first with legacy tiling Tvrtko Ursulin
2015-10-16 12:03 ` [PATCH i-g-t 1/3] lib/igt_fb: Allow specifiying object tiling when creating frame buffers Ville Syrjälä
2015-10-16 12:19 ` Tvrtko Ursulin
2015-10-16 12:29 ` Ville Syrjälä
2015-10-16 12:54 ` Tvrtko Ursulin
2015-10-16 13:01 ` Ville Syrjälä
2015-10-16 13:06 ` Tvrtko Ursulin [this message]
2015-10-17 2:47 ` [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier Vivek Kasireddy
2015-10-19 10:20 ` Tvrtko Ursulin
2015-10-20 1:14 ` Vivek Kasireddy
2015-10-20 9:10 ` Tvrtko Ursulin
2015-10-21 1:41 ` Vivek Kasireddy
2015-10-22 1:24 ` [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v2) Vivek Kasireddy
2015-10-22 9:56 ` Tvrtko Ursulin
2015-10-23 1:34 ` [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v3) Vivek Kasireddy
2015-10-23 8:51 ` Tvrtko Ursulin
2015-10-23 11:35 ` Daniel Vetter
2015-10-24 1:03 ` Vivek Kasireddy
2015-10-27 10:37 ` Tvrtko Ursulin
2015-10-29 1:48 ` [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v4) Vivek Kasireddy
2015-10-29 10:33 ` Tvrtko Ursulin
2015-10-30 1:44 ` [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v5) Vivek Kasireddy
2015-10-30 10:22 ` Tvrtko Ursulin
2015-10-31 1:45 ` Vivek Kasireddy
2015-11-02 9:41 ` Tvrtko Ursulin
2015-11-02 13:36 ` [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v3) Thomas Wood
2015-11-03 1:25 ` [PATCH] igt/kms_rotation_crc: Add a new subtest to exhaustively test for fence leaks Vivek Kasireddy
2015-11-03 10:02 ` Tvrtko Ursulin
2015-11-04 2:25 ` [PATCH] igt/kms_rotation_crc: Add a new subtest to exhaustively test for fence leaks (v2) Vivek Kasireddy
2015-11-04 10:07 ` Tvrtko Ursulin
2015-11-05 0:10 ` [PATCH] igt/kms_rotation_crc: Add a new subtest to exhaustively test for fence leaks (v3) Vivek Kasireddy
2015-11-05 9:46 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620F638.9020509@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.