Re: [Qemu-devel] [PATCH] watchdog: add support to emulate winbond w83627thf

[Paolo Bonzini <pbonzini@redhat.com>]

On 16/10/2015 16:46, Daniel Fahlgren wrote:
> The spec can be found at
> http://www.alldatasheet.com/datasheet-pdf/pdf/206865/WINBOND/W83627THF.html
> 
> To quote the datasheet about the other features:
> 
> "83627THF is a Winbond LPC I/O product. It integrates the following
> major peripheral functions in a chip: the disk driver adapter (FDC),
> Serial port (UART), Parallel port (SPP/EPP/ECP), Keyboard controller
> (KBC), SIR, Game port, MIDI port, Hardware Monitor, ACPI, On Now Wake-Up
> features."
> 
> My reason for implementing this watchdog is that I have a Linux system
> image that depends on /dev/watchdog being present. That image only has a
> single kernel module for watchdogs enabled which happened to be this
> one. So no advantages except diversity and giving the users the option
> to choose from different devices.

I see.  Since you modeled it as an ISA device, it makes sense to extract
the watchdog out of the SuperIO chip.  Can you write a testcase similar
to tests/wdt_ib700-test.c?  With that we can accept the patch.

Thanks,

Paolo