From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Franklin S Cooper Jr." Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect Date: Fri, 16 Oct 2015 10:47:27 -0500 Message-ID: <56211C0F.4090102@ti.com> References: <1445009343-28307-1-git-send-email-fcooper@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , , Mark Brown , Sekhar Nori , , "Ivan T. Ivanov" , , "Ivan T. Ivanov" , Jarkko Nikula , To: Andy Shevchenko Return-path: In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 10/16/2015 10:45 AM, Andy Shevchenko wrote: > On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr wrote: >> SPI controllers may need to be properly setup before chip selects >> can be used. Therefore, wait until the spi controller has a chance >> to perform their setup procedure before trying to use the chip >> select. >> >> This also insures that the chip selects pins are in a good >> state before asseting them which otherwise may cause confusion. >> >> Signed-off-by: Franklin S Cooper Jr > Does it mean I have to test it again? Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included. > >> --- >> Keystone 2 devices currently fail to boot in linux-next after the >> below commit was applied: >> >> spi: bitbang: switch to the generic implementation of transfer_one_message >> commit: 0037686596832572bbca05ab168d9884d7d704c1 >> >> This patch allows Keystone 2 devices to boot again in linux-next. >> >> Tested this patch on K2E evm and am437 starterkit which both have SPI >> devices to insure regressions aren't seen. >> >> V2 Changes: >> Update commit message. >> >> drivers/spi/spi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c >> index 4c638f3..9d5525a 100644 >> --- a/drivers/spi/spi.c >> +++ b/drivers/spi/spi.c >> @@ -2059,11 +2059,11 @@ int spi_setup(struct spi_device *spi) >> if (!spi->max_speed_hz) >> spi->max_speed_hz = spi->master->max_speed_hz; >> >> - spi_set_cs(spi, false); >> - >> if (spi->master->setup) >> status = spi->master->setup(spi); >> >> + spi_set_cs(spi, false); >> + >> dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n", >> (int) (spi->mode & (SPI_CPOL | SPI_CPHA)), >> (spi->mode & SPI_CS_HIGH) ? "cs_high, " : "", >> -- >> 2.6.1 >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933083AbbJPPrj (ORCPT ); Fri, 16 Oct 2015 11:47:39 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:47234 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932875AbbJPPrh (ORCPT ); Fri, 16 Oct 2015 11:47:37 -0400 From: "Franklin S Cooper Jr." To: Andy Shevchenko CC: "linux-kernel@vger.kernel.org" , , Mark Brown , Sekhar Nori , , "Ivan T. Ivanov" , , "Ivan T. Ivanov" , Jarkko Nikula , Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect References: <1445009343-28307-1-git-send-email-fcooper@ti.com> Message-ID: <56211C0F.4090102@ti.com> Date: Fri, 16 Oct 2015 10:47:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 10:45 AM, Andy Shevchenko wrote: > On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr wrote: >> SPI controllers may need to be properly setup before chip selects >> can be used. Therefore, wait until the spi controller has a chance >> to perform their setup procedure before trying to use the chip >> select. >> >> This also insures that the chip selects pins are in a good >> state before asseting them which otherwise may cause confusion. >> >> Signed-off-by: Franklin S Cooper Jr > Does it mean I have to test it again? Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included. > >> --- >> Keystone 2 devices currently fail to boot in linux-next after the >> below commit was applied: >> >> spi: bitbang: switch to the generic implementation of transfer_one_message >> commit: 0037686596832572bbca05ab168d9884d7d704c1 >> >> This patch allows Keystone 2 devices to boot again in linux-next. >> >> Tested this patch on K2E evm and am437 starterkit which both have SPI >> devices to insure regressions aren't seen. >> >> V2 Changes: >> Update commit message. >> >> drivers/spi/spi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c >> index 4c638f3..9d5525a 100644 >> --- a/drivers/spi/spi.c >> +++ b/drivers/spi/spi.c >> @@ -2059,11 +2059,11 @@ int spi_setup(struct spi_device *spi) >> if (!spi->max_speed_hz) >> spi->max_speed_hz = spi->master->max_speed_hz; >> >> - spi_set_cs(spi, false); >> - >> if (spi->master->setup) >> status = spi->master->setup(spi); >> >> + spi_set_cs(spi, false); >> + >> dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n", >> (int) (spi->mode & (SPI_CPOL | SPI_CPHA)), >> (spi->mode & SPI_CS_HIGH) ? "cs_high, " : "", >> -- >> 2.6.1 >> > >