From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v3] raisin: enable ovmf build for arm64
Date: Fri, 16 Oct 2015 19:39:34 +0100
Message-ID: <56214466.6040003@citrix.com>
References: <1444995779-29218-1-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1444995779-29218-1-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 16/10/15 12:42, Stefano Stabellini wrote:
>  function ovmf_check_package() {
> -    local DEP_Debian_common="build-essential nasm uuid-dev python iasl"
> -    local DEP_Debian_x86_32="$DEP_Debian_common"
> -    local DEP_Debian_x86_64="$DEP_Debian_common"
> -    local DEP_Debian_arm32="$DEP_Debian_common"
> +    local DEP_Debian_common="build-essential uuid-dev python iasl"
> +    local DEP_Debian_x86_32="$DEP_Debian_common nasm"
> +    local DEP_Debian_x86_64="$DEP_Debian_x86_32"
>      local DEP_Debian_arm64="$DEP_Debian_common"
>  
> -    local DEP_Fedora_common="make gcc gcc-c++ nasm libuuid-devel python acpica-tools"
> -    local DEP_Fedora_x86_32="$DEP_Fedora_common"
> -    local DEP_Fedora_x86_64="$DEP_Fedora_common"
> +    local DEP_Fedora_common="make gcc gcc-c++ libuuid-devel python acpica-tools"
> +    local DEP_Fedora_x86_32="$DEP_Fedora_common nasm"
> +    local DEP_Fedora_x86_64="$DEP_Fedora_x86_32"
> +    local DEP_Fedora_arm64="$DEP_Debian_common"

Shouldn't it be $DEP_Fedora_common here?

> +
> +    local DEP_CentOS_common="$DEP_Fedora_common"
> +    local DEP_CentOS_x86_32="$DEP_Fedora_x86_32"
> +    local DEP_CentOS_x86_64="$DEP_Fedora_x86_64"
> +    local DEP_CentOS_arm64="$DEP_Fedora_arm64"

It's bit strange to introduce DEP_CentOS_* in a patch which only enable
ARM64. Is it intentional?

Regards,

-- 
Julien Grall