* [PATCH v2] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall
@ 2015-10-17 0:25 Leonid Yegoshin
0 siblings, 0 replies; 4+ messages in thread
From: Leonid Yegoshin @ 2015-10-17 0:25 UTC (permalink / raw)
To: paul.burton, richard, linux-kernel, ralf, luto, alex.smith,
markos.chandras
MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly
set to processing aka rt_sigaction() variant only.
Fixed.
--
v2: Taken in account CONFIG vars interdependencies and conditional expression
simplified. As a result, the reverse problem fixed (introduced by v1).
Tested on all 3 ABIs.
--
---
arch/mips/include/asm/signal.h | 12 +++++++++---
arch/mips/kernel/signal.c | 2 +-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/mips/include/asm/signal.h b/arch/mips/include/asm/signal.h
index 003e273eff4c..2292373ff11a 100644
--- a/arch/mips/include/asm/signal.h
+++ b/arch/mips/include/asm/signal.h
@@ -11,11 +11,17 @@
#include <uapi/asm/signal.h>
+#ifdef CONFIG_MIPS32_COMPAT
+extern struct mips_abi mips_abi_32;
-#ifdef CONFIG_TRAD_SIGNALS
-#define sig_uses_siginfo(ka) ((ka)->sa.sa_flags & SA_SIGINFO)
+#define sig_uses_siginfo(ka, abi) \
+ ((abi != &mips_abi_32) ? 1 : \
+ ((ka)->sa.sa_flags & SA_SIGINFO))
#else
-#define sig_uses_siginfo(ka) (1)
+#define sig_uses_siginfo(ka, abi) \
+ (config_enabled(CONFIG_64BIT) ? 1 : \
+ (config_enabled(CONFIG_TRAD_SIGNALS) ? \
+ ((ka)->sa.sa_flags & SA_SIGINFO) : 1) )
#endif
#include <asm/sigcontext.h>
diff --git a/arch/mips/kernel/signal.c b/arch/mips/kernel/signal.c
index bf792e2839a6..5f18d0b879e0 100644
--- a/arch/mips/kernel/signal.c
+++ b/arch/mips/kernel/signal.c
@@ -798,7 +798,7 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs)
regs->regs[0] = 0; /* Don't deal with this again. */
}
- if (sig_uses_siginfo(&ksig->ka))
+ if (sig_uses_siginfo(&ksig->ka, abi))
ret = abi->setup_rt_frame(vdso + abi->vdso->off_rt_sigreturn,
ksig, regs, oldset);
else
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall
@ 2015-10-17 0:25 ` Leonid Yegoshin
0 siblings, 0 replies; 4+ messages in thread
From: Leonid Yegoshin @ 2015-10-17 0:25 UTC (permalink / raw)
To: linux-mips, paul.burton, richard, linux-kernel, ralf, luto,
alex.smith, markos.chandras
MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly
set to processing aka rt_sigaction() variant only.
Fixed.
--
v2: Taken in account CONFIG vars interdependencies and conditional expression
simplified. As a result, the reverse problem fixed (introduced by v1).
Tested on all 3 ABIs.
--
---
arch/mips/include/asm/signal.h | 12 +++++++++---
arch/mips/kernel/signal.c | 2 +-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/mips/include/asm/signal.h b/arch/mips/include/asm/signal.h
index 003e273eff4c..2292373ff11a 100644
--- a/arch/mips/include/asm/signal.h
+++ b/arch/mips/include/asm/signal.h
@@ -11,11 +11,17 @@
#include <uapi/asm/signal.h>
+#ifdef CONFIG_MIPS32_COMPAT
+extern struct mips_abi mips_abi_32;
-#ifdef CONFIG_TRAD_SIGNALS
-#define sig_uses_siginfo(ka) ((ka)->sa.sa_flags & SA_SIGINFO)
+#define sig_uses_siginfo(ka, abi) \
+ ((abi != &mips_abi_32) ? 1 : \
+ ((ka)->sa.sa_flags & SA_SIGINFO))
#else
-#define sig_uses_siginfo(ka) (1)
+#define sig_uses_siginfo(ka, abi) \
+ (config_enabled(CONFIG_64BIT) ? 1 : \
+ (config_enabled(CONFIG_TRAD_SIGNALS) ? \
+ ((ka)->sa.sa_flags & SA_SIGINFO) : 1) )
#endif
#include <asm/sigcontext.h>
diff --git a/arch/mips/kernel/signal.c b/arch/mips/kernel/signal.c
index bf792e2839a6..5f18d0b879e0 100644
--- a/arch/mips/kernel/signal.c
+++ b/arch/mips/kernel/signal.c
@@ -798,7 +798,7 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs)
regs->regs[0] = 0; /* Don't deal with this again. */
}
- if (sig_uses_siginfo(&ksig->ka))
+ if (sig_uses_siginfo(&ksig->ka, abi))
ret = abi->setup_rt_frame(vdso + abi->vdso->off_rt_sigreturn,
ksig, regs, oldset);
else
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall
@ 2015-10-17 0:25 ` Leonid Yegoshin
0 siblings, 0 replies; 4+ messages in thread
From: Leonid Yegoshin @ 2015-10-17 0:25 UTC (permalink / raw)
To: linux-mips, paul.burton, richard, linux-kernel, ralf, luto,
alex.smith, markos.chandras
MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly
set to processing aka rt_sigaction() variant only.
Fixed.
--
v2: Taken in account CONFIG vars interdependencies and conditional expression
simplified. As a result, the reverse problem fixed (introduced by v1).
Tested on all 3 ABIs.
--
---
arch/mips/include/asm/signal.h | 12 +++++++++---
arch/mips/kernel/signal.c | 2 +-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/mips/include/asm/signal.h b/arch/mips/include/asm/signal.h
index 003e273eff4c..2292373ff11a 100644
--- a/arch/mips/include/asm/signal.h
+++ b/arch/mips/include/asm/signal.h
@@ -11,11 +11,17 @@
#include <uapi/asm/signal.h>
+#ifdef CONFIG_MIPS32_COMPAT
+extern struct mips_abi mips_abi_32;
-#ifdef CONFIG_TRAD_SIGNALS
-#define sig_uses_siginfo(ka) ((ka)->sa.sa_flags & SA_SIGINFO)
+#define sig_uses_siginfo(ka, abi) \
+ ((abi != &mips_abi_32) ? 1 : \
+ ((ka)->sa.sa_flags & SA_SIGINFO))
#else
-#define sig_uses_siginfo(ka) (1)
+#define sig_uses_siginfo(ka, abi) \
+ (config_enabled(CONFIG_64BIT) ? 1 : \
+ (config_enabled(CONFIG_TRAD_SIGNALS) ? \
+ ((ka)->sa.sa_flags & SA_SIGINFO) : 1) )
#endif
#include <asm/sigcontext.h>
diff --git a/arch/mips/kernel/signal.c b/arch/mips/kernel/signal.c
index bf792e2839a6..5f18d0b879e0 100644
--- a/arch/mips/kernel/signal.c
+++ b/arch/mips/kernel/signal.c
@@ -798,7 +798,7 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs)
regs->regs[0] = 0; /* Don't deal with this again. */
}
- if (sig_uses_siginfo(&ksig->ka))
+ if (sig_uses_siginfo(&ksig->ka, abi))
ret = abi->setup_rt_frame(vdso + abi->vdso->off_rt_sigreturn,
ksig, regs, oldset);
else
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall
2015-10-17 0:25 ` Leonid Yegoshin
(?)
@ 2015-10-17 11:13 ` Sergei Shtylyov
-1 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-10-17 11:13 UTC (permalink / raw)
To: Leonid Yegoshin, linux-mips, paul.burton, richard, linux-kernel,
ralf, luto, alex.smith, markos.chandras
Hello.
On 10/17/2015 3:25 AM, Leonid Yegoshin wrote:
> MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly
> set to processing aka rt_sigaction() variant only.
>
> Fixed.
> --
> v2: Taken in account CONFIG vars interdependencies and conditional expression
> simplified. As a result, the reverse problem fixed (introduced by v1).
> Tested on all 3 ABIs.
> --
You forgot to sign off this time.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-17 11:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-17 0:25 [PATCH v2] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall Leonid Yegoshin
2015-10-17 0:25 ` Leonid Yegoshin
2015-10-17 11:13 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2015-10-17 0:25 Leonid Yegoshin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.