Re: [PATCH] ohci-pci: use PCI_DEVICE_SUB()

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 10/17/2015 9:39 AM, Greg KH wrote:

>> Toshiba  Portege 4000 quirk entry can be written shorter using the
>> PCI_DEVICE_SUB() macro.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.
>>
>>   drivers/usb/host/ohci-pci.c |    6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> Index: usb/drivers/usb/host/ohci-pci.c
>> ===================================================================
>> --- usb.orig/drivers/usb/host/ohci-pci.c
>> +++ usb/drivers/usb/host/ohci-pci.c
>> @@ -192,10 +192,8 @@ static const struct pci_device_id ohci_p
>>   	},
>>   	{
>>   		/* Toshiba portege 4000 */
>> -		.vendor		= PCI_VENDOR_ID_AL,
>> -		.device		= 0x5237,
>> -		.subvendor	= PCI_VENDOR_ID_TOSHIBA,
>> -		.subdevice	= 0x0004,
>> +		PCI_DEVICE_SUB(PCI_VENDOR_ID_AL, 0x5237,
>> +			       PCI_VENDOR_ID_TOSHIBA, 0x0004),
>
> But it's much less readable now, right?

    To me, the field names like sub{vendor|device} also don't seem very 
readable, I'd prefer subsys_{vendor|device}. Does your logic extend to using 
the mere USB_DEVICE() macro too?

> Why make this change then?

    For brevity's sake. The same reason they called the fields sub{vendor|device}.

> sorry,
>
> greg k-h

MBR, Sergei