From: Richard Weinberger <richard@nod.at>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
linux-mtd@lists.infradead.org
Cc: hs@denx.de
Subject: Re: [PATCH] UBI: Fastmap: Fix PEB array type
Date: Sat, 17 Oct 2015 20:04:06 +0200 [thread overview]
Message-ID: <56228D96.7070408@nod.at> (raw)
In-Reply-To: <1445104555-30509-1-git-send-email-ezequiel@vanguardiasur.com.ar>
Am 17.10.2015 um 19:55 schrieb Ezequiel Garcia:
> The PEB array is an array of __be32, so let's fix the
> scan_pool() prototype accordingly.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/mtd/ubi/fastmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index db3defdfc3c0..c867707a1d04 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -383,7 +383,7 @@ static void unmap_peb(struct ubi_attach_info *ai, int pnum)
> * < 0 indicates an internal error.
> */
> static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
> - int *pebs, int pool_size, unsigned long long *max_sqnum,
> + __be32 *pebs, int pool_size, unsigned long long *max_sqnum,
> struct list_head *eba_orphans, struct list_head *free)
> {
> struct ubi_vid_hdr *vh;
The change makes sense, but does it fix a real issue?
I suspect it silences a compiler warning, which one?
Thanks,
//richard
next prev parent reply other threads:[~2015-10-17 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 17:55 [PATCH] UBI: Fastmap: Fix PEB array type Ezequiel Garcia
2015-10-17 18:04 ` Richard Weinberger [this message]
2015-10-17 18:10 ` Ezequiel Garcia
2015-11-06 22:18 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56228D96.7070408@nod.at \
--to=richard@nod.at \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hs@denx.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.