From: Jan Beulich <jbeulich@suse.com>
To: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Cc: "Stefano Stabellini" <stefano.stabellini@amd.com>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>,
"Petre Pircalabu" <ppircalabu@bitdefender.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Tamas K Lengyel" <tamas@tklengyel.com>,
"Ayan Kumar Halder" <ayan.kumar.halder@amd.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 4/4] xen: mem_access: conditionally compile vm_event.c & monitor.c
Date: Thu, 30 Jan 2025 14:32:17 +0100 [thread overview]
Message-ID: <56231f2c-d57e-423c-b4bd-19d06aeda6ec@suse.com> (raw)
In-Reply-To: <2e8b9c5390019ef66610a21d9a8744282e2badeb.1737452864.git.Sergiy_Kibrik@epam.com>
On 21.01.2025 11:25, Sergiy Kibrik wrote:
> --- a/xen/include/xen/monitor.h
> +++ b/xen/include/xen/monitor.h
> @@ -27,8 +27,17 @@
> struct domain;
> struct xen_domctl_monitor_op;
>
> +#ifdef CONFIG_VM_EVENT
> int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
> void monitor_guest_request(void);
> +#else
> +static inline int monitor_domctl(struct domain *d,
> + struct xen_domctl_monitor_op *mop)
> +{
> + return -EINVAL;
EOPNOTSUPP perhaps?
Otherwise looks okay to me, but first and foremost requires Arm side approval.
Jan
next prev parent reply other threads:[~2025-01-30 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 10:17 [PATCH v2 0/4] make build of vm_event/mem_access/monitor optional Sergiy Kibrik
2025-01-21 10:19 ` [PATCH v2 1/4] xen: kconfig: rename MEM_ACCESS -> VM_EVENT Sergiy Kibrik
2025-01-30 13:24 ` Jan Beulich
2025-01-31 0:26 ` Tamas K Lengyel
2025-01-31 6:30 ` Jan Beulich
2025-01-31 23:36 ` Tamas K Lengyel
2025-02-03 7:36 ` Jan Beulich
2025-02-04 1:07 ` Tamas K Lengyel
2025-01-30 13:26 ` Jan Beulich
2025-01-31 0:29 ` Tamas K Lengyel
2025-01-21 10:21 ` [PATCH v2 2/4] x86:monitor: control monitor.c build with CONFIG_VM_EVENT option Sergiy Kibrik
2025-01-30 13:27 ` Jan Beulich
2025-01-21 10:23 ` [PATCH v2 3/4] automation: rename CONFIG_MEM_ACCESS -> CONFIG_VM_EVENT Sergiy Kibrik
2025-01-22 8:03 ` Nicola Vetrini
2025-01-30 13:14 ` Jan Beulich
2025-01-21 10:25 ` [PATCH v2 4/4] xen: mem_access: conditionally compile vm_event.c & monitor.c Sergiy Kibrik
2025-01-30 13:32 ` Jan Beulich [this message]
2025-01-31 0:33 ` Tamas K Lengyel
2025-01-31 6:42 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56231f2c-d57e-423c-b4bd-19d06aeda6ec@suse.com \
--to=jbeulich@suse.com \
--cc=Sergiy_Kibrik@epam.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=ayan.kumar.halder@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=ppircalabu@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.