Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5

[Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On 10/18/2015 08:49 AM, Bjorn Andersson wrote:
> On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
>> MDP5 has a different compatible string (which causes checkpatch warnings
>> when we try to add MDP5 device nodes). It also has different list of
>> clocks.
>>
>> Update the bindings for MDP5.
>>
>> Signed-off-by: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>>   Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 ++++++++++++++++-------
>>   1 file changed, 16 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt b/Documentation/devicetree/bindings/drm/msm/mdp.txt
>> index 1a0598e..e926daa 100644
>> --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt
>> +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt
>> @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller
>>   Required properties:
>>   - compatible:
>>     * "qcom,mdp" - mdp4
>> +  * "qcom,mdss_mdp" - mdp5
>
> Wouldn't it be better to name these "qcom,mdp4" and "qcom,mdp5" so
> that we don't have to rely on some magic detection mechanism to
> support future versions?

My guess is that compatibility string "mdss_mdp" came from the
downstream kernels. Chips having MDP4 were supported on downstream
kernels that preceded DT.

Since we don't have any MDP DT upstream, I think we could go with the
string names you suggested. It might break things for people who might
try to use an old downstream dts file with a new kernel. But that
doesn't sound like the worst thing.

Archit

>
> Regards,
> Bjorn
>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html