Re: [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm

["Roger Pau Monné" <roger.pau@citrix.com>]

El 19/10/15 a les 11.09, Jan Beulich ha escrit:
>>>> On 19.10.15 at 11:02, <wei.liu2@citrix.com> wrote:
>> On Sat, Oct 17, 2015 at 10:55:52PM +0000, osstest service owner wrote:
>>> branch xen-unstable
>>> xen branch xen-unstable
>>> job test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm
>>> test debian-hvm-install
>>>
>>> Tree: linux git://xenbits.xen.org/linux-pvops.git
>>> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
>>> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
>>> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
>>> Tree: xen git://xenbits.xen.org/xen.git
>>>
>>> *** Found and reproduced problem changeset ***
>>>
>>>   Bug is in tree:  xen git://xenbits.xen.org/xen.git
>>>   Bug introduced:  c64ef24febcf5bc6c6da733abd256412da8c4895
>>>   Bug not present: 2fe4c0060c62a012109dab1d981522dc26822110
>>>
>>>
>>>   commit c64ef24febcf5bc6c6da733abd256412da8c4895
>>>   Author: Roger Pau Monne <roger.pau@citrix.com>
>>>   Date:   Fri Oct 2 17:48:33 2015 +0200
>>>
>>>       libxc: split x86 HVM setup_guest into smaller logical functions
>>>
>>>       This is just a preparatory change to clean up the code in setup_guest.
>>>       Should not introduce any functional changes.
>>>
>>>       Signed-off-by: Roger Pau Monn?? <roger.pau@citrix.com>
>>>       Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>       Acked-by: Wei Liu <wei.liu2@citrix.com>
>>>       Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>>       Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>       Cc: Ian Campbell <ian.campbell@citrix.com>
>>>       Cc: Wei Liu <wei.liu2@citrix.com>
>>>
>>>
>>> For bisection revision-tuple graph see:
>>>    
>> http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test 
>> -amd64-i386-xl-qemuu-debianhvm-amd64-xsm.debian-hvm-install.html
>>> Revision IDs in each graph node refer, respectively, to the Trees above.
>>>
>>
>> The bug has been fixed in staging and we already got a push.
> 
> And that fix is commit c787425fdf ("libxc: fix the types used in
> xc_dom_image to build HVM guests")? I ask because the commit
> message doesn't say anything like that, and it's not immediately
> clear why only an *-xsm test should have been affected by the
> issue.

The problem was not related to XSM in any way, this specific XSM test
failed simply because the HVM guest had more than 4GB of RAM and the
toolstack was 32bits (which was the only way to trigger it). I wrongly
used xen_pfn_t to store byte memory addresses in xc_dom_image.

Roger.