From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: sunxi: Add icnova-a20-swac defconfig and dts file
Date: Mon, 19 Oct 2015 13:53:01 +0200 [thread overview]
Message-ID: <5624D99D.8000800@denx.de> (raw)
In-Reply-To: <5624D7B5.2030705@redhat.com>
Hi Hans,
On 19.10.2015 13:44, Hans de Goede wrote:
<snip>
>>>>> diff --git a/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
>>>>> b/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
>>>>> new file mode 100644
>>>>
>>>> Please submit this file also to the upstream kernel.
>>>
>>> Yes. The name of the DT especially doesn't really make sense. The
>>> "SWAC" name isn't referenced anywhere, the module cannot be used
>>> alone, and there's a single combination available (A20 SODIMM +
>>> ADB4006)
>>
>> At least one other combination is available. A custom board from SWAC
>> equipped with the SoM. What is the preferred method to support SoM's
>> with multiple baseboards? Something like:
>>
>> sun7i-a20-icnova.dtsi
>> sun7i-a20-icnova-adb4006.dts
>> sun7i-a20-icnova-swac.dts
>>
>> ?
>>
>>>>
>>>>> index 0000000..773fb6f
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
>>>>> @@ -0,0 +1,177 @@
>>>>> +/*
>>>>> + * Copyright 2013 Maxime Ripard
>>>>> + *
>>>>> + * Maxime Ripard <maxime.ripard@free-electrons.com>
>>>
>>> And I'm *not* the copyright owner here.
>>
>> Okay. Hans, do you want me to change this (and potential other
>> changes as well - see file naming above) via a follow-up patch
>> once its available in mainline U-Boot?
>
> Actually I would prefer to get this right in one go, esp. the
> filename bits, having u-boot and the kernel disagreeing on the
> dtb filename is no good. So I plan to remove this version of
> the patch from u-boot-sunxi/next for now. Once you and Maxime
> agree on a dts / dtb filename please submit a new version and
> I'll merge that one instead.
Sure. Lets do it this way.
Thanks,
Stefan
next prev parent reply other threads:[~2015-10-19 11:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 9:41 [U-Boot] [PATCH] arm: sunxi: Add icnova-a20-swac defconfig and dts file Stefan Roese
2015-10-17 13:47 ` Hans de Goede
2015-10-18 9:34 ` Maxime Ripard
2015-10-19 10:48 ` Stefan Roese
2015-10-19 11:44 ` Hans de Goede
2015-10-19 11:53 ` Stefan Roese [this message]
2015-10-20 8:06 ` Ian Campbell
2015-10-21 14:31 ` Maxime Ripard
2015-10-21 14:44 ` Stefan Roese
2015-10-22 7:57 ` Maxime Ripard
2015-10-19 10:38 ` Stefan Roese
2015-10-19 11:42 ` Hans de Goede
2015-10-20 8:05 ` Ian Campbell
2015-10-19 10:38 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5624D99D.8000800@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.