From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754117AbbJSNev (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Oct 2015 09:34:51 -0400
Received: from mail-io0-f173.google.com ([209.85.223.173]:35949 "EHLO
	mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752505AbbJSNet (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Oct 2015 09:34:49 -0400
Subject: Re: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine_str'
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
References: <1445241870-24854-1-git-send-email-mingo@kernel.org>
 <1445241870-24854-9-git-send-email-mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>
From: David Ahern <dsahern@gmail.com>
Message-ID: <5624F176.5040801@gmail.com>
Date: Mon, 19 Oct 2015 07:34:46 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1445241870-24854-9-git-send-email-mingo@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/19/15 2:04 AM, Ingo Molnar wrote:
> @@ -128,7 +128,7 @@ static void __bench_mem_routine(struct bench_mem_info *info, int r_idx, size_t l
>   	double result_bps = 0.0;
>   	u64 result_cycles = 0;
>
> -	printf("Routine %s (%s)\n", r->name, r->desc);
> +	printf("routine %s (%s)\n", r->name, r->desc);
>
>   	if (bench_format == BENCH_FORMAT_DEFAULT)
>   		printf("# Copying %s Bytes ...\n\n", length_str);

Seems like 'R' is more appropriate here.