From mboxrd@z Thu Jan 1 00:00:00 1970 From: michal.simek@xilinx.com (Michal Simek) Date: Mon, 19 Oct 2015 16:09:09 +0200 Subject: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform. In-Reply-To: <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> References: <1445035350-3569-1-git-send-email-moritz.fischer@ettus.com> <1445035350-3569-3-git-send-email-moritz.fischer@ettus.com> <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> Message-ID: <5624F985.8050905@xilinx.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/18/2015 07:53 PM, Josh Cartwright wrote: > On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: >> Added addtional nodes required for FPGA Manager operation >> of the Xilinx Zynq Devc configuration interface. >> >> Reviewed-by: S?ren Brinkmann >> Signed-off-by: Moritz Fischer >> --- >> >> v2: No changes >> >> --- >> arch/arm/boot/dts/zynq-7000.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi >> index dc0457e..1a5220e 100644 >> --- a/arch/arm/boot/dts/zynq-7000.dtsi >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi >> @@ -294,6 +294,11 @@ >> devcfg: devcfg at f8007000 { >> compatible = "xlnx,zynq-devcfg-1.0"; >> reg = <0xf8007000 0x100>; >> + interrupt-parent = <&intc>; > > You shouldn't need interrupt-parent here. In fact, I suspect it can be > removed from all sibling nodes as well. Correct. But I tend to do it vice-versa. To remove it from amba node and keep it in every IP here. The reason is simple to let everybody know that setting up right interrupt controller is something what they have to care. If you have more interrupt controllers in the system it can be messy. But again. Please remove this patch from this series. This will go to mainline through arm-soc but 1/3 and 3/3 will go through Greg. That's why please do not include it here. Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform. Date: Mon, 19 Oct 2015 16:09:09 +0200 Message-ID: <5624F985.8050905@xilinx.com> References: <1445035350-3569-1-git-send-email-moritz.fischer@ettus.com> <1445035350-3569-3-git-send-email-moritz.fischer@ettus.com> <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151018175324.GH12756-ew3lsbMjNqt5wtABiV/Xjqyly8cj88Ttqxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Josh Cartwright , Moritz Fischer Cc: michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/18/2015 07:53 PM, Josh Cartwright wrote: > On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: >> Added addtional nodes required for FPGA Manager operation >> of the Xilinx Zynq Devc configuration interface. >> >> Reviewed-by: S=F6ren Brinkmann >> Signed-off-by: Moritz Fischer >> --- >> >> v2: No changes >> >> --- >> arch/arm/boot/dts/zynq-7000.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zy= nq-7000.dtsi >> index dc0457e..1a5220e 100644 >> --- a/arch/arm/boot/dts/zynq-7000.dtsi >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi >> @@ -294,6 +294,11 @@ >> devcfg: devcfg@f8007000 { >> compatible =3D "xlnx,zynq-devcfg-1.0"; >> reg =3D <0xf8007000 0x100>; >> + interrupt-parent =3D <&intc>; >=20 > You shouldn't need interrupt-parent here. In fact, I suspect it can = be > removed from all sibling nodes as well. Correct. But I tend to do it vice-versa. To remove it from amba node an= d keep it in every IP here. The reason is simple to let everybody know that setting up right interrupt controller is something what they have to care. If you have more interrupt controllers in the system it can be messy. But again. Please remove this patch from this series. This will go to mainline through arm-soc but 1/3 and 3/3 will go through Greg. That's why please do not include it here. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790AbbJSOJW (ORCPT ); Mon, 19 Oct 2015 10:09:22 -0400 Received: from mail-bl2on0077.outbound.protection.outlook.com ([65.55.169.77]:44640 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751063AbbJSOJT (ORCPT ); Mon, 19 Oct 2015 10:09:19 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform. To: Josh Cartwright , Moritz Fischer References: <1445035350-3569-1-git-send-email-moritz.fischer@ettus.com> <1445035350-3569-3-git-send-email-moritz.fischer@ettus.com> <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> CC: , , , , , , , , , , , , From: Michal Simek Message-ID: <5624F985.8050905@xilinx.com> Date: Mon, 19 Oct 2015 16:09:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21888.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD045;1:hywTyk4L+t0CskYPn52/mk5BZbEuZGBQjT+NoAtRdanvhejDzPBh8EOexVEhDeIJuHrld86eTy5WQMbL12u5HSY/zTB6ziIOcVuP0FENGDa/U7LRN3nZYbdOyqVWAzzcgjCftPy6gTSG0koiHCGX+7jBePk3m6CtVfPxG+1oUkyTPdw7/QFLLlFhPdVqmkDYgs317I1/xom8A+mC2TQ4u0uyfnJEy9Q+KIs/s/eqLghPFP1LhJx5mxDDB1xv7CfNFuJOIBhYGGFbt3LSj2yRbfYs65K6BTOHVzV61UiJLDfZNbx89MS/hTxH3UtarHveB8U2q9PhYTxTIDegUkoKYVDaHB3C3CpbIRMDPjMvcRuPEEIF7lwqHoDfZnhbAel+ X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(377454003)(24454002)(199003)(479174004)(164054003)(5001770100001)(5001960100002)(92566002)(4001350100001)(65956001)(23746002)(63266004)(5001920100001)(81156007)(36386004)(106466001)(64126003)(189998001)(76176999)(54356999)(65816999)(33656002)(87936001)(87266999)(50986999)(80316001)(86362001)(50466002)(19580395003)(65806001)(19580405001)(64706001)(47776003)(2950100001)(59896002)(46102003)(11100500001)(5008740100001)(5007970100001)(36756003)(83506001)(77096005)(6806005)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB048;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB048;2:xlGCjJzSxL8RYTv4OUprMWQIaBceIqupefkYkeoZnaP/prLE1cziJrf3Krl6adHoZUmOgPzcpLEqt11phcUuo3LIZzsiVofmDgX8/OqUE4h2Z0I2TvWd5GUih6UsoFTuMDlPVGCX/A7iDvuyYDHwUUC8gkaHdEUWjt6kV/uRT18=;3:hkMvfR3Jwa1wPC1BL0bVqWRwvjOAiXPJF6iC+fRBlIkerg5TQcvwQWIFNvd018medJ9KlsFqSTNJF9D+apop5ckuC72aGNVYaS4/K45EdQCil1t7UMNA8PPtnX65EWz1YG4YqZ6MRTnuwR4klvn8m/GdEkjfITG6k2Rbkm6DtTsKOQwb/HfJxR36r3TgdlWvt9Btqj1/BsFvioecFCgufagz89YNqiZKs6DxI9oge5rwLR37vzbzGK4C2qPTPfp/TKVKNFbu7rbaVdDD8mh56g==;25:rV6W1gH4BYPLxhapCyxBvLsR69IWm9hkfXtkfbdZ29654V1GVp8GIDjRyHXKsrcj674sgZZ/KEO8hnElqvVJBxLbHDOysLutMIalILjgrVPEtS1vdnw1cWAlaGL65uAeKZLqT13THwTAdfsOOiAu5nC9HXxWNR97r53sGd/zOvGThMxF5Ej3qH+Mn1uOB/OiIXfSiHpirFHJjyjekRAojHyn3hg4xdr9PPEHIyQM10iLSyhGqm0Ph4CbO62i3bxz X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1BFFO11HUB048; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB048;20:bQC72GsGFn3iXpavWjDaBdnpl3ZnLuP/Wc5AyhEbhodsQsbWMePGL+6FyXrk+tJn2OKX21ijQB0sfNVRxHmj5yh3fUEfOhzDECqXmu0oXhvj137SS3uwdnRuyw51Yy6g0MP9b4piIzHk1CeMdIZVwdiCJzvS7LPYLRxP8lsCIBUhPUEDtgL5icSRL4IXMpgk3hRrTdvCxy98I+wNEBf13FIszeErVlSJoXnd0gzi6xO0bPyuFkbSDc2Xv2eA/IDQtyZSkz3wyNlYXXhJNEGRNnddSziNb0RgQGBiJ2reEHQDuqROK2zoYDkzama9HKUu9rlToDR7RYStYyhT6EXdwsXSbapjR9AaD+H2RaG8YwiPUBQclW1WLNeASjZ4DFaRNEtlqKNlTEXjFy4FppIAt/4ZGKaKKap56xO5jrp7E+itMQVrd4UeOsGPdiWrrOjc63oXmoe0V1doysvLTejpC6jw5+043++zEtR/H87ij4qN246pMzIS487x17REAqFx;4:JI9NvhO74I44Tl1y+xCcKpXwHDahfTSCfUain2340+EUaTVhScZpb3EhB4nhBVWaMwlLtOv8OTFODMKsamUkvTuCy9NcvzGdOVrlwU3KEPdjFNAQn12qSLOAqXRotsIIssmuO/54WpPWOP53BKQrYT5EQjghFbM7OlaQdl/Ik/4pwcHXa7aoAeAcHMSAuNlPkAP7bt1XGh/4EYAlnLNqYtrlGY5mXMvPmW42zS3z/gWP+fcHr1qK4Czxtvd5ep9gi5gerA2didGN/Ijqs6Vd5E7EH6IRgTCcuDpTNe6Tah40uWvAVCGQtD9eRZDPL3z1ev1lrJ+oDBgs6IRgSdY1mAAcJCwhxSZcMju89uwND0p9mxwtgV25n8J9hSoCCB9R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10115024);SRVR:BN1BFFO11HUB048;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB048; X-Forefront-PRVS: 07349BFAD2 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1BFFO11HUB048;23:roEwEDJw17o/HC4H0em5896yER2lgajpDh/?= =?Windows-1252?Q?+pwnElAKjWIpTo2NqRp2jvpdYbymsnYL7dhZHtS8CqZ75drXdLxOtk+y?= =?Windows-1252?Q?cNzUFcpew6qh8yp77vlxeLH/Mm3rHB2CTDwrSL39Q3BLiImVdfrwYZ8p?= =?Windows-1252?Q?x80dLjz5eFHPOW8qCTwSUFSkep7yu5/ec7MPMpK4GRVJE/HHZO2A15iK?= =?Windows-1252?Q?cymyQvx0RhebLeM4NqA0wh577DG5VsvQ7VRTupS3KoNTyh4rwYdDvJfC?= =?Windows-1252?Q?2XBuA0jnAILNSPOa597HNM9DcRP7T9hvArpFI5MW6VGQpUGfrxOWGdMR?= =?Windows-1252?Q?ZY5cROxj6XmOBoPlSSWwPAZzUJN3iRq6tXhu269X50SmdHfhmdEuoMgT?= =?Windows-1252?Q?Oe2KYlnikdrgj7k2AiqkCuL55FEZRKKZIKOeQwTbnvQAG+Bvh5h+z0/d?= =?Windows-1252?Q?MYpPY6IEbch66yqA2eKbBa30aXYns8SeHdM8XFyWAEyJ7Jq6CYz7ynby?= =?Windows-1252?Q?GIdzpsZHTGILxCEKX29/sNx3mh57AO+fiRV36S5xBYU/11wtf11gqKMt?= =?Windows-1252?Q?M94/P0tfuksVrYjBEQDfd4zbEoivD9dciLA9pZsjsKGN3sm7i8GdiYrS?= =?Windows-1252?Q?mJGc0aSlrYeM/+u5A4FWlLka+HEVCY7qNw5MqYs3Xu/So0Vnhf75WZ9v?= =?Windows-1252?Q?EwcqenbNwFxq/IwNUkC1nh6iMCnxNc2yLQPl93cd4gDueQV8Gr/Sl+Lv?= =?Windows-1252?Q?fCrClAmjLAYCvUCyH42ixxlvLIPeY0zOnwM9JgIJQ0VVIxAcEF4oTWOc?= =?Windows-1252?Q?C6G2aFkjSFbjd/7ajhDDe4IvEikfwjc3B6Whbqg0/wJ2N4k3EBTqMBLU?= =?Windows-1252?Q?2OyKWbJuwXEiwSLK9WVwJY5Eif/zGw+qv5RRhcbBeiuq0hDaPmfodvPy?= =?Windows-1252?Q?M7/aW6sSFb5WDl491erFgY8wzVYsjBLiyQy/EXuKUQSY0Z2uO7T0ooMd?= =?Windows-1252?Q?8vpvXXuDXcC+BC2o0K5AuuMRSf+Yg5HJA5tgVpgp9wJXHZsK9AjJ+U/T?= =?Windows-1252?Q?tkzbL6XtLuZu9WHbTnqLkgYUDRuTwoudcHewPcbxUfl91tHBdXgzjV3I?= =?Windows-1252?Q?H9Ajc3SKb48Qxn9h1SN+f9gyXtJHPJfVEGyEVS8cEfDcZEngbZcvt3Je?= =?Windows-1252?Q?SC/IXNN7Ed+HoReUEqyWLzV14yokCp0W9eY2KzNLDl9RTCT09eb3sDnx?= =?Windows-1252?Q?e/OsbkdyTs0m9Pyt9YHFLsDC42F9aDCAzmz5X8H6ZurwErYZTd5+YmKn?= =?Windows-1252?Q?ofW6fCcV5lpXR4RniEEKnvVX2LgKelqN3NYecbjBLFaNXbw0Dajg353K?= =?Windows-1252?Q?vUzOo7BQcUsjy?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB048;5:lY6mzUAOUER0kxcnvWIKfjozNlU3wTwg0s8uFZScbeAaPUkAbHFExq4Rrbn+GC1208Qz1zKJPZyzw+OjuG/NL1/to6bFqQML7dtEBjs+/I0RyYJYIeecHyEyuteNnxC0KwmzXxj3ug+MGvHrgEM01Q==;24:PVfk+DPgnyNpDXnXHgiR5znS/X6wbRxD4ia6lCw8P9plrLamRK3gk3O6MY7LQVWfmNl9z/9KkqnTOOKw8F8wv/hoUq2tWsuQ66pp33AWyqc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2015 14:09:16.8560 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB048 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB029;2:SFLuuBDeFa7kcgIsASIUO1tzboeOxMXtCfli/tPRNgMAYyikDVzM+/FwpVOMhTmf2DyDK4rz8Cy/CRWTVCoRvUB3mqa8Mzw/zxDxpyIOo/6FzmnIAiTEXbUgx5xVB6/4yU0gTCjfAdGYr5Rc9Y0ZdT7dcYggppFYNsCWk2kVSEM=;23:B/tsgnd/Qj23W+SopbHrr3WZ7w/3vtvrxHGKx8CRRphTzlcex3JowiK1yZm8kkj2g/OhaA6jAJOfhcY3p7mQIeSeAl0rzLYwgsl9Vfj5sppV/b1mu7WB9w4196i2Kf7jCoMeGlGJ6zF17xx/I0Cy02aQ8wfq0w49bav8V52Q/xsvycp7rR8zPco1UdSoQUJ/ X-OriginatorOrg: xilinx.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2015 07:53 PM, Josh Cartwright wrote: > On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: >> Added addtional nodes required for FPGA Manager operation >> of the Xilinx Zynq Devc configuration interface. >> >> Reviewed-by: Sören Brinkmann >> Signed-off-by: Moritz Fischer >> --- >> >> v2: No changes >> >> --- >> arch/arm/boot/dts/zynq-7000.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi >> index dc0457e..1a5220e 100644 >> --- a/arch/arm/boot/dts/zynq-7000.dtsi >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi >> @@ -294,6 +294,11 @@ >> devcfg: devcfg@f8007000 { >> compatible = "xlnx,zynq-devcfg-1.0"; >> reg = <0xf8007000 0x100>; >> + interrupt-parent = <&intc>; > > You shouldn't need interrupt-parent here. In fact, I suspect it can be > removed from all sibling nodes as well. Correct. But I tend to do it vice-versa. To remove it from amba node and keep it in every IP here. The reason is simple to let everybody know that setting up right interrupt controller is something what they have to care. If you have more interrupt controllers in the system it can be messy. But again. Please remove this patch from this series. This will go to mainline through arm-soc but 1/3 and 3/3 will go through Greg. That's why please do not include it here. Thanks, Michal