Re: [PATCH] iio: accel: add Freescale MMA7455L 3-axis accelerometer driver

[Lars-Peter Clausen <lars@metafoo.de>]

On 10/19/2015 04:09 PM, Martin Kepplinger wrote:
> Am 2015-10-19 um 15:43 schrieb Joachim Eastwood:
>> On 19 October 2015 at 14:56, Martin Kepplinger <martink@posteo.de> wrote:
>>> Am 2015-10-19 um 14:34 schrieb Joachim Eastwood:
>>>> Hi Martin,
>>>>
>>>> On 19 October 2015 at 13:10, Martin Kepplinger <martink@posteo.de> wrote:
>>>>> Am 2015-10-18 um 00:25 schrieb Joachim Eastwood:
>>>>>> Add support for Freescale MMA7455L 3-axis in 10-bit mode with both
>>>>>> I2C and SPI bus support. This is a rather simple driver that
>>>>>> currently doesn't support all the hardware features of MMA7455L.
>>>>>>
>>>>>> Tested on Embedded Artists' LPC4357 Dev Kit using I2C bus.
>>>>>>
>>>>>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
>>>>>> ---
>>>>>
>>>>> Think about adding support for MMA7456L as well. What's the difference
>>>>> between the two, except for the ID?
>>>>
>>>> I think the driver should work with MMA7456L as well.
>>>> I have tried to figure out the difference between the two devices, but
>>>> the Freescale doesn't list them. One another annoying thing is that
>>>> the ID isn't actually stated in the data sheet (!). So for MMA7456L I
>>>> would guess it is 0x56, but there is no way to be sure.
>>>>
>>>
>>> You're right, that's messy. I asked freescale about it and we'll see
>>> if/when there's an answer.
>>
>> ah, nice. Thanks for taking the time to doing that.
>>
> 
> MMA7456L's WHO_AM_I value should also be 0x55, see
> https://community.freescale.com/thread/378035
> 
> You could think about renaming the driver to mma745xl which is this
> "series".

Please no X's in driver names. That's always a mess if multiple different
types of devices match the name. E.g. lets say they release a MMA7459 which
is a gyro or whatever in the future.

Just name the driver after the first device supported.