From mboxrd@z Thu Jan 1 00:00:00 1970 From: m-karicheri2@ti.com (Murali Karicheri) Date: Mon, 19 Oct 2015 11:28:19 -0400 Subject: [PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional In-Reply-To: <5621030D.4090800@ti.com> References: <1444935553-19760-1-git-send-email-m-karicheri2@ti.com> <5621030D.4090800@ti.com> Message-ID: <56250C13.708@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/16/2015 10:00 AM, Murali Karicheri wrote: > On 10/15/2015 02:59 PM, Murali Karicheri wrote: >> When firmware image for PDSP firmware is absent in the file system >> the kernel boot with ramfs/nfs is stuck for 60 seconds being the >> the default timeout. request_firmware_direct() is to take care of >> such optional firmware loading and hence replace the call in the >> driver with this API. >> >> Signed-off-by: Murali Karicheri >> --- >> drivers/soc/ti/knav_qmss_queue.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/soc/ti/knav_qmss_queue.c >> b/drivers/soc/ti/knav_qmss_queue.c >> index f3a0b6a..89789e2 100644 >> --- a/drivers/soc/ti/knav_qmss_queue.c >> +++ b/drivers/soc/ti/knav_qmss_queue.c >> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct >> knav_device *kdev, >> >> for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) { >> if (knav_acc_firmwares[i]) { >> - ret = request_firmware(&fw, >> - knav_acc_firmwares[i], >> - kdev->dev); >> + ret = request_firmware_direct(&fw, >> + knav_acc_firmwares[i], >> + kdev->dev); >> if (!ret) { >> found = true; >> break; >> > Santosh, > > If this looks good, could you please send this to linux-next? Without > this, Linux boot will see a pause for about 60 seconds if qmss acc > firmware is not present in the file system. So this is a must for next. > Santosh, A Gentle ping.... Murali -- Murali Karicheri Linux Kernel, Keystone From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754333AbbJSP2h (ORCPT ); Mon, 19 Oct 2015 11:28:37 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:46644 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbbJSP2f (ORCPT ); Mon, 19 Oct 2015 11:28:35 -0400 Message-ID: <56250C13.708@ti.com> Date: Mon, 19 Oct 2015 11:28:19 -0400 From: Murali Karicheri Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: , , Subject: Re: [PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional References: <1444935553-19760-1-git-send-email-m-karicheri2@ti.com> <5621030D.4090800@ti.com> In-Reply-To: <5621030D.4090800@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 10:00 AM, Murali Karicheri wrote: > On 10/15/2015 02:59 PM, Murali Karicheri wrote: >> When firmware image for PDSP firmware is absent in the file system >> the kernel boot with ramfs/nfs is stuck for 60 seconds being the >> the default timeout. request_firmware_direct() is to take care of >> such optional firmware loading and hence replace the call in the >> driver with this API. >> >> Signed-off-by: Murali Karicheri >> --- >> drivers/soc/ti/knav_qmss_queue.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/soc/ti/knav_qmss_queue.c >> b/drivers/soc/ti/knav_qmss_queue.c >> index f3a0b6a..89789e2 100644 >> --- a/drivers/soc/ti/knav_qmss_queue.c >> +++ b/drivers/soc/ti/knav_qmss_queue.c >> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct >> knav_device *kdev, >> >> for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) { >> if (knav_acc_firmwares[i]) { >> - ret = request_firmware(&fw, >> - knav_acc_firmwares[i], >> - kdev->dev); >> + ret = request_firmware_direct(&fw, >> + knav_acc_firmwares[i], >> + kdev->dev); >> if (!ret) { >> found = true; >> break; >> > Santosh, > > If this looks good, could you please send this to linux-next? Without > this, Linux boot will see a pause for about 60 seconds if qmss acc > firmware is not present in the file system. So this is a must for next. > Santosh, A Gentle ping.... Murali -- Murali Karicheri Linux Kernel, Keystone