From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@oracle.com (santosh shilimkar) Date: Mon, 19 Oct 2015 08:29:56 -0700 Subject: [PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional In-Reply-To: <56250C13.708@ti.com> References: <1444935553-19760-1-git-send-email-m-karicheri2@ti.com> <5621030D.4090800@ti.com> <56250C13.708@ti.com> Message-ID: <56250C74.8010405@oracle.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/19/2015 8:28 AM, Murali Karicheri wrote: > On 10/16/2015 10:00 AM, Murali Karicheri wrote: >> On 10/15/2015 02:59 PM, Murali Karicheri wrote: >>> When firmware image for PDSP firmware is absent in the file system >>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the >>> the default timeout. request_firmware_direct() is to take care of >>> such optional firmware loading and hence replace the call in the >>> driver with this API. >>> >>> Signed-off-by: Murali Karicheri >>> --- >>> drivers/soc/ti/knav_qmss_queue.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/soc/ti/knav_qmss_queue.c >>> b/drivers/soc/ti/knav_qmss_queue.c >>> index f3a0b6a..89789e2 100644 >>> --- a/drivers/soc/ti/knav_qmss_queue.c >>> +++ b/drivers/soc/ti/knav_qmss_queue.c >>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct >>> knav_device *kdev, >>> >>> for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) { >>> if (knav_acc_firmwares[i]) { >>> - ret = request_firmware(&fw, >>> - knav_acc_firmwares[i], >>> - kdev->dev); >>> + ret = request_firmware_direct(&fw, >>> + knav_acc_firmwares[i], >>> + kdev->dev); >>> if (!ret) { >>> found = true; >>> break; >>> >> Santosh, >> >> If this looks good, could you please send this to linux-next? Without >> this, Linux boot will see a pause for about 60 seconds if qmss acc >> firmware is not present in the file system. So this is a must for next. >> > Santosh, > > A Gentle ping.... > Yes I have seen it but it has to wait now. I plan to send that as a fix as part of 4.4-rcx fixes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754440AbbJSPah (ORCPT ); Mon, 19 Oct 2015 11:30:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:16561 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754288AbbJSPad (ORCPT ); Mon, 19 Oct 2015 11:30:33 -0400 Subject: Re: [PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional To: Murali Karicheri , ssantosh@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1444935553-19760-1-git-send-email-m-karicheri2@ti.com> <5621030D.4090800@ti.com> <56250C13.708@ti.com> From: santosh shilimkar Organization: Oracle Corporation Message-ID: <56250C74.8010405@oracle.com> Date: Mon, 19 Oct 2015 08:29:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56250C13.708@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2015 8:28 AM, Murali Karicheri wrote: > On 10/16/2015 10:00 AM, Murali Karicheri wrote: >> On 10/15/2015 02:59 PM, Murali Karicheri wrote: >>> When firmware image for PDSP firmware is absent in the file system >>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the >>> the default timeout. request_firmware_direct() is to take care of >>> such optional firmware loading and hence replace the call in the >>> driver with this API. >>> >>> Signed-off-by: Murali Karicheri >>> --- >>> drivers/soc/ti/knav_qmss_queue.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/soc/ti/knav_qmss_queue.c >>> b/drivers/soc/ti/knav_qmss_queue.c >>> index f3a0b6a..89789e2 100644 >>> --- a/drivers/soc/ti/knav_qmss_queue.c >>> +++ b/drivers/soc/ti/knav_qmss_queue.c >>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct >>> knav_device *kdev, >>> >>> for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) { >>> if (knav_acc_firmwares[i]) { >>> - ret = request_firmware(&fw, >>> - knav_acc_firmwares[i], >>> - kdev->dev); >>> + ret = request_firmware_direct(&fw, >>> + knav_acc_firmwares[i], >>> + kdev->dev); >>> if (!ret) { >>> found = true; >>> break; >>> >> Santosh, >> >> If this looks good, could you please send this to linux-next? Without >> this, Linux boot will see a pause for about 60 seconds if qmss acc >> firmware is not present in the file system. So this is a must for next. >> > Santosh, > > A Gentle ping.... > Yes I have seen it but it has to wait now. I plan to send that as a fix as part of 4.4-rcx fixes.