All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org,
	James.Bottomley@HansenPartnership.com
Cc: jthumshirn@suse.de
Subject: Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target
Date: Mon, 19 Oct 2015 08:36:23 -0700	[thread overview]
Message-ID: <56250DF7.6050803@sandisk.com> (raw)
In-Reply-To: <20151019143546.GA7486@lst.de>

On 10/19/2015 07:35 AM, Christoph Hellwig wrote:
> When dropping a lock while iterating a list we must restart the search
> as other threads could have manipulated the list under us.  Without this
> we can get stuck in an endless loop.

Hello Christoph,

Thanks for looking into this. However, I think we need a motivation in 
the patch description why this patch does not reintroduce the soft 
lockup documented in patch "scsi_remove_target: fix softlockup 
regression on hot remove" (commit bc3f02a795d3).

Thanks,

Bart.

  reply	other threads:[~2015-10-19 15:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 14:35 [PATCH] scsi: restart list search after unlock in scsi_remove_target Christoph Hellwig
2015-10-19 15:36 ` Bart Van Assche [this message]
2015-10-19 15:56   ` Christoph Hellwig
2015-10-19 16:01     ` James Bottomley
2015-10-19 17:21     ` Dan Williams
2015-10-26  8:35 ` Johannes Thumshirn
2015-10-27 20:14   ` Bart Van Assche
2015-10-30  8:26     ` Johannes Thumshirn
2015-10-27 16:33 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56250DF7.6050803@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.