From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754112AbbJSQJ3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Oct 2015 12:09:29 -0400
Received: from mail-pa0-f54.google.com ([209.85.220.54]:35974 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752419AbbJSQJ2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Oct 2015 12:09:28 -0400
Subject: Re: [PATCH 2/2] perf test: Suppress libtraceevent warnings
To: Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
References: <1445268229-1601-1-git-send-email-namhyung@kernel.org>
 <1445268229-1601-2-git-send-email-namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Wang Nan <wangnan0@huawei.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <562515B6.3050904@gmail.com>
Date: Mon, 19 Oct 2015 10:09:26 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1445268229-1601-2-git-send-email-namhyung@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/19/15 9:23 AM, Namhyung Kim wrote:
> Currently libtraceevent emits warning on unsupported event formats.
> However it'd be better to see them only -v option is given.  To do that,
> it needs to override the warning() function which is used in the
> libtracevent.  Thus add set_warning_routine() same as set_die_routine()
> and check the verbose flag in our warning routine.
>
> Before:
>    # perf test 5
>     5: parse events tests                                       :
>      Warning: [kvmmmu:kvm_mmu_get_page] bad op token {
>      Warning: [kvmmmu:kvm_mmu_sync_page] bad op token {
>      Warning: [kvmmmu:kvm_mmu_unsync_page] bad op token {
>      Warning: [kvmmmu:kvm_mmu_prepare_zap_page] bad op token {
>      Warning: [kvmmmu:fast_page_fault] function is_writable_pte not defined
>      ...
>     Ok
>
> After:
>    # perf test 5
>     5: parse events tests                                       : Ok
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>   tools/perf/tests/parse-events.c | 14 ++++++++++++++
>   tools/perf/util/usage.c         |  5 +++++
>   tools/perf/util/util.h          |  1 +
>   3 files changed, 20 insertions(+)
>

Acked-by: David Ahern <dsahern@gmail.com>