From: Eric Blake <eblake@redhat.com>
To: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pkrempa@redhat.com, stefanha@gmail.com,
deepakcs@redhat.com, bharata@linux.vnet.ibm.com,
rtalur@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path]
Date: Mon, 19 Oct 2015 14:10:22 -0600 [thread overview]
Message-ID: <56254E2E.7090705@redhat.com> (raw)
In-Reply-To: <1445256783-28558-2-git-send-email-prasanna.kalever@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On 10/19/2015 06:13 AM, Prasanna Kumar Kalever wrote:
> for example in 'servers' tuple values we use 'server' variable for key 'host'
> in the code, it will be quite messy to have colliding names for variables,
> so to maintain better readability and makes it consistent with other existing
> code as well as the input keys/options, this patch renames the following
> variables
> 'server' -> 'host'
> 'image' -> 'path'
> 'volname' -> 'volume'
>
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> ---
> block/gluster.c | 54 +++++++++++++++++++++++++++---------------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
As mentioned on 1/3, I suspect you want to reorder your series to put
this one first.
Seems fairly mechanical.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-19 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:13 [Qemu-devel] [PATCH 1/3] block/gluster: add support for multiple gluster servers Prasanna Kumar Kalever
2015-10-19 12:13 ` [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path] Prasanna Kumar Kalever
2015-10-19 20:10 ` Eric Blake [this message]
2015-10-19 12:13 ` [Qemu-devel] [PATCH 3/3] block/gluster: code cleanup Prasanna Kumar Kalever
2015-10-19 20:08 ` [Qemu-devel] [PATCH 1/3] block/gluster: add support for multiple gluster servers Eric Blake
2015-10-20 7:23 ` Prasanna Kumar Kalever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56254E2E.7090705@redhat.com \
--to=eblake@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=deepakcs@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=prasanna.kalever@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rtalur@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.