From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 6/6] iotests: Test changed Quorum filename
Date: Mon, 19 Oct 2015 15:13:48 -0600 [thread overview]
Message-ID: <56255D0C.8020809@redhat.com> (raw)
In-Reply-To: <1445280546-26226-7-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On 10/19/2015 12:49 PM, Max Reitz wrote:
> After drive-mirror replacing a Quorum child, the filename of the Quorum
> BDS should reflect the change. This patch replaces the existing test for
> whether the operation did actually exchange the BDS (which simply tested
> whether the new BDS existed) by a test which examines the children list
> contained in the Quorum BDS's filename as returned by query-block.
>
> As a nice side effect of confirming that the new BDS actually belongs to
> the Quorum BDS, this checks whether the filename was properly updated.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/041 | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-19 21:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 18:49 [Qemu-devel] [PATCH v5 0/6] block: Drop BDS.filename Max Reitz
2015-10-19 18:49 ` [Qemu-devel] [PATCH v5 1/6] block: Change bdrv_get_encrypted_filename() Max Reitz
2015-10-19 20:15 ` Eric Blake
2015-10-26 18:20 ` Kevin Wolf
2015-10-19 18:49 ` [Qemu-devel] [PATCH v5 2/6] block: Avoid BlockDriverState.filename Max Reitz
2015-10-19 20:35 ` Eric Blake
2015-10-26 16:51 ` Kevin Wolf
2015-10-19 18:49 ` [Qemu-devel] [PATCH v5 3/6] block: Add bdrv_filename() Max Reitz
2015-10-19 20:52 ` Eric Blake
2015-10-26 18:20 ` Kevin Wolf
2015-10-19 18:49 ` [Qemu-devel] [PATCH v5 4/6] qemu-img: Use bdrv_filename() for map Max Reitz
2015-10-19 21:02 ` Eric Blake
2015-10-26 18:21 ` Kevin Wolf
2015-10-19 18:49 ` [Qemu-devel] [PATCH v5 5/6] block: Drop BlockDriverState.filename Max Reitz
2015-10-19 21:11 ` Eric Blake
2015-10-27 9:39 ` Kevin Wolf
2015-10-19 18:49 ` [Qemu-devel] [PATCH v5 6/6] iotests: Test changed Quorum filename Max Reitz
2015-10-19 21:13 ` Eric Blake [this message]
2015-10-27 9:41 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56255D0C.8020809@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.