From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <linux-mtd@lists.infradead.org>,
Richard Weinberger <richard@nod.at>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH v2 3/3] mtd: tests: introduce a erase test
Date: Tue, 20 Oct 2015 09:42:34 +0800 [thread overview]
Message-ID: <56259C0A.6020201@cn.fujitsu.com> (raw)
In-Reply-To: <20151020012028.GE13239@google.com>
On 10/20/2015 09:20 AM, Brian Norris wrote:
> On Mon, Oct 19, 2015 at 06:18:13PM -0700, Brian Norris wrote:
>> + others
>
> really +others this time!
>
>> On Wed, Sep 30, 2015 at 09:01:21AM +0800, Dongsheng Yang wrote:
>>> This test will test the below cases.
>>>
[...]
>>> +
>>> +MODULE_DESCRIPTION("Erase test module");
>>> +MODULE_AUTHOR("Dongsheng Yang");
>>> +MODULE_LICENSE("GPL");
>>
>> Overall, I'm not sure if this test is really that useful. It does a few
>> sanity checks on the API, but it doesn't really test the erase function
>> itself. If anyone else thinks this test is interesting though, I suppose
>> there's not much harm in putting it into mtd-utils tests/.
Yes, I found the erase problem about mtdram in my debugging. Then
I was wondering why we did not find it by running mtd/tests. Finally
I found there is no testing about it in mtd/tests. So write one and
send it out here.
As you said, it's much more proper to put them in mtd-utils. I am
totally agree with that. would port it to userspace.
Thanx
Yang
>>
>> Brian
> .
>
prev parent reply other threads:[~2015-10-20 1:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201509300759.Ipr62suj%fengguang.wu@intel.com>
[not found] ` <560B293B.2060001@cn.fujitsu.com>
2015-09-30 0:29 ` [l2-mtd:master 149/149] ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined! Brian Norris
2015-09-30 1:01 ` [PATCH v2 0/3] mtdram: check offs and len in mtdram->erase Dongsheng Yang
2015-09-30 1:01 ` [PATCH v2 1/3] mtd: " Dongsheng Yang
2015-10-20 1:09 ` Brian Norris
2015-09-30 1:01 ` [PATCH v2 2/3] mtd: test: refactor mtdtest_erase_eraseblock to introduce a new mtdtest_erase function Dongsheng Yang
2015-09-30 1:01 ` [PATCH v2 3/3] mtd: tests: introduce a erase test Dongsheng Yang
2015-10-20 1:18 ` Brian Norris
2015-10-20 1:20 ` Brian Norris
2015-10-20 1:42 ` Dongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56259C0A.6020201@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.