All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Andre <marc.andre@netline.ch>
To: Lars-Peter Clausen <lars@metafoo.de>, jic23@kernel.org
Cc: knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: iio:ad5064: Add support for LTC2617
Date: Tue, 20 Oct 2015 07:59:44 +0200	[thread overview]
Message-ID: <5625D850.7060201@netline.ch> (raw)
In-Reply-To: <5624D136.9030100@metafoo.de>



On 19.10.2015 13:17, Lars-Peter Clausen wrote:
> On 10/15/2015 02:31 PM, Marc Andre wrote:
>> I've updated the patches according to the feedback of Peter and Daniel.
>> - Added datasheet links to the description of patch 1/2.
>> - Added 90kohm_to_gnd to ABI documentation sysfs-bus-iio
>>
> Looks good to me. You can add
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
> I'd prefer though if you change the order of the patches. Patch 1 refactor
> the macros so you can specify the ext_info. Patch 2 add support for the LTC
> devices, this way we don't end up with a intermediate step where power-down
> is broken.
I will do that, but I am currently traveling on a business trip, I will 
send it towards the end of the week. I assume I can put the Acked-by on 
as long as the code doesn't change.

>> **** Original intro *****
>>
>> Based on the discussion after submitting my patch to add a new driver
>> for LTC2617, I've now implemented the support for the LTC2617 (and
>> similar) devices into the AD5064 driver.
>>
>> I've split the implementation into two patches. The first patch adds
>> basic support for LTC2617. The second patch fixes the power down
>> functionality because the LTC handle that differently than the AD
>> devices.
>>
>> [PATCH v2 1/2] iio:ad5064: Add support for ltc2617 and similar devices
>> [PATCH v2 2/2] iio:ad5064: Fix power down operation with LTC2617
>>
>> Best Regards,
>> Marc
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Marc André, André-Netline
eBusiness-Solutions

André-Netline
Könizstr. 161
CH-3097 Liebefeld

Tel. 031 974 16 66
Fax: 031 974 16 65
marc.andre@netline.ch
http://www.netline.ch


      reply	other threads:[~2015-10-20  5:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  9:12 iio:ad5064: Add support for LTC2617 Marc Andre
2015-10-15  9:12 ` [PATCH 1/2] iio:ad5064: Add support for ltc2617 and similar devices Marc Andre
2015-10-15  9:12 ` [PATCH 2/2] iio:ad5064: Fix power down operation with LTC2617 Marc Andre
2015-10-15 10:27   ` Peter Meerwald
2015-10-15 10:30 ` iio:ad5064: Add support for LTC2617 Daniel Baluta
2015-10-15 12:31   ` Marc Andre
2015-10-15 12:31     ` [PATCH v2 1/2] iio:ad5064: Add support for ltc2617 and similar devices Marc Andre
2015-10-15 12:31     ` [PATCH v2 2/2] iio:ad5064: Fix power down operation with LTC2617 Marc Andre
2015-10-19 11:17     ` iio:ad5064: Add support for LTC2617 Lars-Peter Clausen
2015-10-20  5:59       ` Marc Andre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5625D850.7060201@netline.ch \
    --to=marc.andre@netline.ch \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.